Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to MVA MET: Fullfills "consumes" call requirement, Bugfix for the calculation of the covariance matrix, updated path to weight files. Same changes as in PR for CMSSW76X #13088

Merged
merged 5 commits into from Feb 1, 2016

Conversation

rfriese
Copy link
Contributor

@rfriese rfriese commented Jan 27, 2016

Same commit as this one:
#13086

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @rfriese (Raphael Friese) for CMSSW_8_0_X.

It involves the following packages:

RecoMET/METPUSubtraction

@cmsbuild, @cvuosalo, @davidlange6, @slava77 can you please review it and eventually sign? Thanks.
@TaiSakuma, @ahinzmann, @mmarionncern, @jdolen, @nhanvtran, @schoef, @mariadalfonso this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@slava77
Copy link
Contributor

slava77 commented Jan 27, 2016

@rfriese
please edit the PR description block and give more details on the changes (plots or a link to a presentation in a POG meeting)

@slava77
Copy link
Contributor

slava77 commented Jan 27, 2016

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10777/console

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented Jan 28, 2016

@rfriese
please update the PR description here as well (descriptive text and a link to the 76X PR would suffice)

@cmsbuild
Copy link
Contributor

Pull request #13088 was updated. @cmsbuild, @cvuosalo, @davidlange6, @slava77 can you please check and sign again.

@slava77
Copy link
Contributor

slava77 commented Jan 28, 2016

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10812/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 1, 2016

Pull request #13088 was updated. @cmsbuild, @cvuosalo, @davidlange6, @slava77 can you please check and sign again.

@cvuosalo
Copy link
Contributor

cvuosalo commented Feb 1, 2016

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 1, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10894/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 1, 2016

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 1, 2016

@cvuosalo
Copy link
Contributor

cvuosalo commented Feb 1, 2016

+1

For #13088 04e5ffc

Bug fix for MVA MET covariance matrix calculation. #13086 is the 76X version of this PR, and it has already been approved.

The code changes are satisfactory, and Jenkins tests against baseline CMSSW_8_0_X_2016-02-01-1100 show no significant differences.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 1, 2016

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

davidlange6 added a commit that referenced this pull request Feb 1, 2016
Update to MVA MET: Fullfills "consumes" call requirement, Bugfix for the calculation of the covariance matrix, updated path to weight files. Same changes as in PR for CMSSW76X
@davidlange6 davidlange6 merged commit 0dba2f0 into cms-sw:CMSSW_8_0_X Feb 1, 2016
cmsbuild added a commit that referenced this pull request Feb 1, 2016
@cvuosalo
Copy link
Contributor

cvuosalo commented Feb 3, 2016

Reference note: Testing shows that this PR does not change the size of Mini-AOD event content.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants