add initial set of Phase2 eras and sub-eras #13097
Conversation
|
A new Pull Request was created by @kpedro88 (Kevin Pedro) for CMSSW_8_0_X. It involves the following packages: Configuration/StandardSequences @cmsbuild, @franzoni, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
|
@kpedro88 - from yesterdays discussion, you'll want instead an era for the scenerio running through gen-sim, one for gen-sim-localreco, and one for gen-sim-reco. Hopefully there aren't as many suberas... |
|
@davidlange6 - I did not conclude that from yesterday's discussion... what is the objection to the current setup? I don't see why we would break the paradigm of subdetector customizations organized in Eras and workflows organized in runTheMatrix. The only point I recall from yesterday's meeting is that we need to add the appropriate geometry cfi's. |
| # Phase2 is everything for the 2023 (2026?) detector that works so far in this release. | ||
| self.Phase2 = cms.Modifier( self.phase2_common, self.phase2_tracker, self.phase2_hgc, self.phase2_muon ) | ||
| # Phase2dev is everything for the 2023 (2026?) detector that is still in development. | ||
| self.Phase2dev = cms.Modifier( self.Phase2, self.phase2dev_common, self.phase2dev_tracker, self.phase2dev_hgc, self.phase2dev_muon ) |
There was a problem hiding this comment.
Just checking the phase2 eras for other reasons, but shouldn't these two be ModifierChains?
kpedro88
force-pushed
the
Phase2-Eras1
branch
from
626929e
to
d16f869
Compare
|
@makortel - Fixed, thanks |
|
Pull request #13097 was updated. @cmsbuild, @franzoni, @davidlange6 can you please check and sign again. |
|
@kpedro88 - its not that anything is wrong - just not general enough - in general we'll need an "era" per geometry scenario (where I think we agree there are 3). |
|
@davidlange6 - I still don't understand why we need a separate era for each different workflow. The customizations needed for e.g. LocalReco should be orthogonal to those needed for Gen-Sim, so they can just be contained in the Phase2 or Phase2dev eras. The era and geometry for each workflow can already be specified in upgradeWorkflowComponents.py... we must somehow be thinking about this differently. Let's discuss more when we meet later in the week. |
add initial set of Phase2 eras and sub-eras
Add a set of Phase2 eras and sub-eras to be used by developers, based on discussion in the Simulation Development hypernews.