Clean up of btag sequence in standard reco + update of DQM #13098

pvmulder · 2016-01-28T09:22:01Z

Removed pfTrackCountingHighPurBJetTags, pfSimpleSecondaryVertexHighPurBJetTags, pfCombinedMVABJetTags, pfCombinedSecondaryVertexBJetTags, pfCombinedSecondaryVertexSoftLeptonBJetTags

Added pfSimpleInclusiveSecondaryVertexHighEffBJetTags

For DQM: added c-tag discriminators + input variables, clean up to monitor relevant taggers (e.g. add pfSimpleSecondaryVertexHighPurBJetTags + removal of irrelevant discriminators)

cmsbuild · 2016-01-28T09:22:22Z

A new Pull Request was created by @pvmulder (Petra Van Mulders) for CMSSW_8_0_X.

It involves the following packages:

DQMOffline/RecoB
PhysicsTools/PatAlgos
RecoBTag/Configuration
RecoBTag/SecondaryVertex
Validation/RecoB

@cvuosalo, @monttj, @cmsbuild, @deguio, @slava77, @vadler, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@TaiSakuma, @imarches, @ahinzmann, @acaudron, @mmarionncern, @rappoccio, @jdolen, @nhanvtran, @schoef, @ferencek, @gpetruc, @mariadalfonso, @pvmulder, @rociovilar this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

ferencek · 2016-01-28T09:33:25Z

PhysicsTools/PatAlgos/python/producersLayer1/jetProducer_cfi.py

        cms.InputTag("pfTrackCountingHighEffBJetTags"),
        cms.InputTag("pfSimpleSecondaryVertexHighEffBJetTags"),
-        cms.InputTag("pfSimpleSecondaryVertexHighPurBJetTags"),
+        cms.InputTag("pfSimpleInclusiveSecondaryVertexHighEffBJetTags"),


For now only remove taggers. pfSimpleInclusiveSecondaryVertexHighEffBJetTags should be added only once new RelVals become available and are propagated to the list of input files for PAT tests.

deguio · 2016-01-28T12:52:53Z

please test

cmsbuild · 2016-01-28T12:53:10Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10801/console

cmsbuild · 2016-01-28T15:03:52Z

-1

Tested at: 2ed110f
I found errors in the following unit tests:

---> test runtestPhysicsToolsPatAlgos had ERRORS

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13098/10801/summary.html

slava77 · 2016-01-28T15:32:08Z

The unit test and the addOn test fail in

Looking for module label: pfSimpleInclusiveSecondaryVertexHighEffBJetTags

this is related to #13098 (diff) #13098 (comment)

slava77 · 2016-01-28T15:35:06Z

DQMOffline/RecoB/interface/FlavourHistorgrams2D.h

+    if ( btppColour  ) col[1] = 4 ;
+    if ( !btppColour ) lineStyle[1] = 2 ;
+  }
+*/ 


cleanup commented out?

slava77 · 2016-01-28T15:42:45Z

@pvmulder
please remove the commented out old taggers.
If you think they may be occasionally useful,
may I suggest to add a customize function that would enable all of them back and put.
I don't find it particularly practical to have to go over n~5 files to uncomment and recover something that was commented out and may be needed for someone's study and then need to recompile.
A simple customization will enable the legacy taggers with much less effort on the user side.

ferencek · 2016-01-28T15:53:48Z

Perhaps it would be best to completely remove all the code, including producers and jet tag computers, related to the old CSV, CSV+SL, and the old CMVA.

cmsbuild · 2016-01-28T16:29:57Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13098/10801/summary.html

ferencek · 2016-01-28T16:35:48Z

Also, don't forget to update PhysicsTools/PatAlgos/test/patTuple_addBTagging_cfg.py accordingly.

acaudron · 2016-02-09T14:13:41Z

So I manage to come back before the merging with:
git reset --hard commitnumber
and I rebase the branch locally with success so I'm remaking my test.
When a branch is rebased, do I need to push it again?
Thanks for the help.

slava77 · 2016-02-09T14:15:31Z

you pushed something already, since the PR is now updated.
If that's not the end, then yes, you will need to push again if there are more changes coming.

…into bTagRecoAndDQMcleanup

cmsbuild · 2016-02-09T14:40:35Z

Pull request #13098 was updated. @cvuosalo, @monttj, @cmsbuild, @deguio, @slava77, @vadler, @vanbesien, @davidlange6 can you please check and sign again.

acaudron · 2016-02-09T14:41:36Z

ok it should be fin now, local tests are fine and the branch is rebased

fabozzi · 2016-02-09T15:33:18Z

please test

cmsbuild · 2016-02-09T15:33:40Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11093/console

cmsbuild · 2016-02-09T18:01:42Z

+1
Tested at: a7f42b5
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13098/11093/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
a7f42b5
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13098/11093/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13098/11093/git-merge-result

cmsbuild · 2016-02-09T18:47:52Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13098/11093/summary.html

cvuosalo · 2016-02-09T23:50:03Z

+1

For #13098 a7f42b5

Second approval after minor clean-up of DQM code. New Jenkins test results are still OK, with the same expected changes as discussed in my first approval message.

bbilin · 2016-02-10T14:35:12Z

Dear all,

Want to let you know that I cleaned the TOP-DQM package for the obsolete taggers and made a PR(# 13241)

Best regards

Bugra, as one of TOP/DQM-PVT contacts

pvmulder · 2016-02-10T14:37:15Z

@PARGALI great!

pvmulder · 2016-02-11T12:44:26Z

@deguio can you have a new look and sign off if ok?

deguio · 2016-02-12T14:17:15Z

+1

Clean up of btag sequence in standard reco + update of DQM

cmsbuild added this to the Next CMSSW_8_0_X milestone Jan 28, 2016

cmsbuild added reconstruction-pending dqm-pending analysis-pending pending-signatures tests-pending orp-pending comparison-pending labels Jan 28, 2016

ferencek reviewed Jan 28, 2016
View reviewed changes

cmsbuild added tests-started and removed tests-pending labels Jan 28, 2016

cmsbuild added tests-rejected and removed tests-started labels Jan 28, 2016

slava77 reviewed Jan 28, 2016
View reviewed changes

cmsbuild added comparison-available and removed comparison-pending labels Jan 28, 2016

cmsbuild added tests-pending comparison-pending and removed comparison-available tests-rejected labels Jan 28, 2016

Move to std::unique_ptr

da48d29

Merge branch 'bTagRecoAndDQMcleanup' of github.com:cms-btv-pog/cmssw …

a7f42b5

…into bTagRecoAndDQMcleanup

cmsbuild added tests-started and removed tests-pending labels Feb 9, 2016

cmsbuild added tests-approved and removed tests-started labels Feb 9, 2016

cmsbuild added comparison-available and removed comparison-pending labels Feb 9, 2016

cmsbuild added reconstruction-approved and removed reconstruction-pending labels Feb 9, 2016

cmsbuild added dqm-approved and removed dqm-pending labels Feb 12, 2016

davidlange6 added a commit that referenced this pull request Feb 12, 2016

Merge pull request #13098 from cms-btv-pog/bTagRecoAndDQMcleanup

23763ec

Clean up of btag sequence in standard reco + update of DQM

davidlange6 merged commit 23763ec into cms-sw:CMSSW_8_0_X Feb 12, 2016

ferencek deleted the bTagRecoAndDQMcleanup branch February 12, 2016 21:13

This was referenced Mar 11, 2016

PAT btag update (81X) #13685

Merged

PAT btag update (80X) #13686

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Clean up of btag sequence in standard reco + update of DQM #13098

Clean up of btag sequence in standard reco + update of DQM #13098

pvmulder commented Jan 28, 2016

cmsbuild commented Jan 28, 2016

ferencek Jan 28, 2016

deguio commented Jan 28, 2016

cmsbuild commented Jan 28, 2016

cmsbuild commented Jan 28, 2016

slava77 commented Jan 28, 2016

slava77 Jan 28, 2016

slava77 commented Jan 28, 2016

ferencek commented Jan 28, 2016

cmsbuild commented Jan 28, 2016

ferencek commented Jan 28, 2016

acaudron commented Feb 9, 2016

slava77 commented Feb 9, 2016

cmsbuild commented Feb 9, 2016

acaudron commented Feb 9, 2016

fabozzi commented Feb 9, 2016

cmsbuild commented Feb 9, 2016

cmsbuild commented Feb 9, 2016

cmsbuild commented Feb 9, 2016

cvuosalo commented Feb 9, 2016

bbilin commented Feb 10, 2016

pvmulder commented Feb 10, 2016

pvmulder commented Feb 11, 2016

deguio commented Feb 12, 2016

Clean up of btag sequence in standard reco + update of DQM #13098

Clean up of btag sequence in standard reco + update of DQM #13098

Conversation

pvmulder commented Jan 28, 2016

cmsbuild commented Jan 28, 2016

ferencek Jan 28, 2016

Choose a reason for hiding this comment

deguio commented Jan 28, 2016

cmsbuild commented Jan 28, 2016

cmsbuild commented Jan 28, 2016

slava77 commented Jan 28, 2016

slava77 Jan 28, 2016

Choose a reason for hiding this comment

slava77 commented Jan 28, 2016

ferencek commented Jan 28, 2016

cmsbuild commented Jan 28, 2016

ferencek commented Jan 28, 2016

acaudron commented Feb 9, 2016

slava77 commented Feb 9, 2016

cmsbuild commented Feb 9, 2016

acaudron commented Feb 9, 2016

fabozzi commented Feb 9, 2016

cmsbuild commented Feb 9, 2016

cmsbuild commented Feb 9, 2016

cmsbuild commented Feb 9, 2016

cvuosalo commented Feb 9, 2016

bbilin commented Feb 10, 2016

pvmulder commented Feb 10, 2016

pvmulder commented Feb 11, 2016

deguio commented Feb 12, 2016