Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FastSim BugFix : PreMix : fix segfault, fix L1 reco, fix digisim link for muons, fix track validation #13125

Merged
merged 7 commits into from Feb 1, 2016

Conversation

lveldere
Copy link
Contributor

replaces #13071, #13110

Lots of fixes in one pr, but they are all entangled

Fix L1 reco, fix seg fault in premix relvals

FastSim no longer runs
SLHCUpgradeSimulations/Configuration/postLS1CustomsPreMixing.customisePostLS1
because it overwrites modification defined in the fastsim era and the run2 eras

New EDAlias for caloStage1LegacyFormatDigis to make the l1extraParticles function properly.

Note: FullSim still runs SLHCUpgradeSimulations/Configuration/postLS1CustomsPreMixing.customisePostLS1 in the DIGI step.
At some point also FullSim should move away from this.

Fix digi-sim links for muons

FastSim now runs
SimGeneral/DataMixingModule/customiseForPremixingInput.customiseForPreMixingInput
This customisation function should not affect anything but validation and dqm,
and the customisation function was modified accordingly.
Note: FullSim had never trouble with this because there the customisation function is only applied on the RECO,VALIDATION,DQM jobs.

Fix track validation

Thanks to SimGeneral/DataMixingModule/customiseForPremixingInput.customiseForPreMixingInput, the tracking particle collection should now include PU tracks

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @lveldere for CMSSW_8_0_X.

It involves the following packages:

Configuration/Applications
Configuration/EventContent
Configuration/PyReleaseValidation
Configuration/StandardSequences
FastSimulation/Configuration
SimGeneral/DataMixingModule

@civanch, @lveldere, @boudoul, @franzoni, @mdhildreth, @fabozzi, @cmsbuild, @ssekmen, @srimanob, @hengne, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @wmtan, @makortel, @GiacomoSguazzoni, @rovere, @VinInn, @Martin-Grunewald, @matt-komm, @cerati, @dgulhan this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@lveldere
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10840/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@mdhildreth
Copy link
Contributor

+1

@fabozzi
Copy link
Contributor

fabozzi commented Jan 31, 2016

+1

davidlange6 added a commit that referenced this pull request Feb 1, 2016
FastSim BugFix : PreMix : fix segfault, fix L1 reco, fix digisim link for muons, fix track validation
@davidlange6 davidlange6 merged commit 9d1bd68 into cms-sw:CMSSW_8_0_X Feb 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants