Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

making HLTConfigProvider correctly handle ignored modules #13215

Merged
merged 1 commit into from Feb 9, 2016

Conversation

Sam-Harper
Copy link
Contributor

HLTConfigProvider sees module names which are ignored as "-modname" rather than "modname". This means when it tries to retrieve the PSet (in which the name is "modname"), it fails and doesnt recognise that it has saveTags=True. The code is now fixed to remove the front "-" if it exists when trying to retrieve the module parameters.

A second fix is for paths which has an ignored HLTLevel1GtSeed module. Currently it things there are two L1Seed modules and as such can not calculate the pre-scale. However there is really only one active one so before pushing back to the list of active L1GTSeeds, it checks if the module is ignore by looking for the "-" in front of the module name.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 8, 2016

A new Pull Request was created by @Sam-Harper for CMSSW_8_0_X.

It involves the following packages:

HLTrigger/HLTcore

@Martin-Grunewald, @perrotta, @cmsbuild, @davidlange6, @fwyzard can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@Martin-Grunewald
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 8, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11066/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 8, 2016

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 8, 2016

@Martin-Grunewald
Copy link
Contributor

+1
Thanks again, Sam!

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 8, 2016

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Feb 9, 2016
making HLTConfigProvider correctly handle ignored modules
@cmsbuild cmsbuild merged commit 73381ad into cms-sw:CMSSW_8_0_X Feb 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants