Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix trackingOnly tracking validation for FastSim and Phase1 #13221

Merged
merged 1 commit into from Feb 15, 2016
Merged

Fix trackingOnly tracking validation for FastSim and Phase1 #13221

merged 1 commit into from Feb 15, 2016

Conversation

makortel
Copy link
Contributor

@makortel makortel commented Feb 8, 2016

This PR fixes a bug introduced in #13172 affecting the trackingOnly MultiTrackValidator configurations for FastSim and Phase1. An incorrect instance of MTV was modified. Thanks to @lveldere for reporting.

Tested in CMSSW_8_0_X_2016-02-07-2300, should have no effect in standard workflows.

@rovere @VinInn

@cmsbuild cmsbuild added this to the Next CMSSW_8_0_X milestone Feb 8, 2016
@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 8, 2016

A new Pull Request was created by @makortel (Matti Kortelainen) for CMSSW_8_0_X.

It involves the following packages:

Validation/RecoTrack

@cmsbuild, @vanbesien, @deguio, @davidlange6 can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @rovere, @VinInn, @cerati, @wmtford, @istaslis, @dgulhan this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@VinInn
Copy link
Contributor

VinInn commented Feb 9, 2016

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 9, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11085/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 9, 2016

-1
Tested at: 2287fd1
When I ran the RelVals I found an error in the following worklfows:
5.1 step1

runTheMatrix-results/5.1_TTbar+TTbarFS+HARVESTFS/step1_TTbar+TTbarFS+HARVESTFS.log

8.0 step1

runTheMatrix-results/8.0_BeamHalo+BeamHalo+DIGICOS+RECOCOS+ALCABH+HARVESTCOS/step1_BeamHalo+BeamHalo+DIGICOS+RECOCOS+ALCABH+HARVESTCOS.log

9.0 step1

runTheMatrix-results/9.0_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST/step1_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST.log

4.22 step2

runTheMatrix-results/4.22_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC/step2_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC.log

25.0 step1

runTheMatrix-results/25.0_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT/step1_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT.log

134.911 step2

runTheMatrix-results/134.911_RunSinglePh2015D+RunSinglePh2015D+HLTDR2_25ns+RECODR2_25nsreHLT+HARVESTDR2_25nsreHLT/step2_RunSinglePh2015D+RunSinglePh2015D+HLTDR2_25ns+RECODR2_25nsreHLT+HARVESTDR2_25nsreHLT.log

135.4 step1

runTheMatrix-results/135.4_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS/step1_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS.log

1306.0 step1

runTheMatrix-results/1306.0_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15/step1_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15.log

1330.0 step1

runTheMatrix-results/1330.0_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15/step1_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15.log

101.0 step1

runTheMatrix-results/101.0_SingleElectronE120EHCAL+SingleElectronE120EHCAL/step1_SingleElectronE120EHCAL+SingleElectronE120EHCAL.log

25202.0 step1

runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25/step1_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25.log

50202.0 step1

runTheMatrix-results/50202.0_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50/step1_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50.log

1000.0 step2

runTheMatrix-results/1000.0_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT/step2_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT.log

140.53 step2

runTheMatrix-results/140.53_RunHI2011+RunHI2011+RECOHID11+HARVESTDHI/step2_RunHI2011+RunHI2011+RECOHID11+HARVESTDHI.log

1001.0 step2

runTheMatrix-results/1001.0_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3+ALCAHARVD4/step2_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3+ALCAHARVD4.log

1003.0 step2

runTheMatrix-results/1003.0_RunMinBias2012A+RunMinBias2012A+RECODDQM+HARVESTDDQM/step2_RunMinBias2012A+RunMinBias2012A+RECODDQM+HARVESTDDQM.log

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13221/11085/summary.html

@makortel
Copy link
Contributor Author

makortel commented Feb 9, 2016

I guess the following for step1 (from 25202) is not caused by this PR:

GEN,SIM,ENDJOB
We have determined that this is simulation (if not, rerun cmsDriver.py with --data)
Traceback (most recent call last):
  File "/afs/cern.ch/cms/sw/ReleaseCandidates/vol1/slc6_amd64_gcc493/cms/cmssw-patch/CMSSW_8_0_X_2016-02-07-2300/bin/slc6_amd64_gcc493/cmsDriver.py", line 55, in <module>
    run()
  File "/afs/cern.ch/cms/sw/ReleaseCandidates/vol1/slc6_amd64_gcc493/cms/cmssw-patch/CMSSW_8_0_X_2016-02-07-2300/bin/slc6_amd64_gcc493/cmsDriver.py", line 27, in run
    configBuilder.prepare()
  File "/afs/cern.ch/cms/sw/ReleaseCandidates/vol1/slc6_amd64_gcc493/cms/cmssw-patch/CMSSW_8_0_X_2016-02-07-2300/python/Configuration/Applications/ConfigBuilder.py", line 2054, in prepare
    self.loadAndRemember(self.EVTCONTDefaultCFF)  #load the event contents regardless
  File "/afs/cern.ch/cms/sw/ReleaseCandidates/vol1/slc6_amd64_gcc493/cms/cmssw-patch/CMSSW_8_0_X_2016-02-07-2300/python/Configuration/Applications/ConfigBuilder.py", line 323, in loadAndRemember
    self.process.load(includeFile)
  File "/afs/cern.ch/cms/sw/ReleaseCandidates/vol1/slc6_amd64_gcc493/cms/cmssw-patch/CMSSW_8_0_X_2016-02-07-2300/python/FWCore/ParameterSet/Config.py", line 511, in load
    module = __import__(moduleName)
  File "/afs/cern.ch/cms/sw/ReleaseCandidates/vol1/slc6_amd64_gcc493/cms/cmssw-patch/CMSSW_8_0_X_2016-02-07-2300/python/Configuration/EventContent/EventContent_cff.py", line 488, in <module>
    RAWSIMEventContent.outputCommands.extend(DigiToRawFEVT.outputCommands)
NameError: name 'DigiToRawFEVT' is not defined

@deguio
Copy link
Contributor

deguio commented Feb 10, 2016

please test

@deguio
Copy link
Contributor

deguio commented Feb 10, 2016

+1

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11131/console

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

-1
Tested at: 2287fd1
I found an error when building:

>> Checking EDM Class Version for src/Validation/RecoVertex/bin/classes_def.xml in libValidationRecoVertexMacros.so
/bin/sh: line 1: 24478 Segmentation fault      ( /afs/cern.ch/cms/sw/ReleaseCandidates/vol1/slc6_amd64_gcc493/cms/cmssw-patch/CMSSW_8_0_X_2016-02-09-1100/src/FWCore/Utilities/scripts/edmCheckClassVersion -l libValidationRecoVertexMacros.so -x $x )
/afs/cern.ch/cms/sw/ReleaseCandidates/vol1/slc6_amd64_gcc493/cms/cmssw/CMSSW_8_0_X_2016-02-07-0000/lib/slc6_amd64_gcc493/libDataFormatsProvenance.so: error adding symbols: Bad address
Suggestion: You can run 'scram build updateclassversion' to generate src/Validation/RecoVertex/bin/classes_def.xml.generated with updated ClassVersion
gmake: **\* [tmp/slc6_amd64_gcc493/src/Validation/RecoVertex/bin/ValidationRecoVertexMacros/libValidationRecoVertexMacros.so] Error 1
collect2: error: ld returned 1 exit status
gmake: **\* [tmp/slc6_amd64_gcc493/src/Validation/RecoVertex/src/ValidationRecoVertex/libValidationRecoVertex.so] Error 1
Copying tmp/slc6_amd64_gcc493/src/DQMServices/Components/test/runFastHadd/runFastHadd to productstore area:
Leaving library rule at src/DQMServices/StreamerIO/test
>> Building edm plugin tmp/slc6_amd64_gcc493/src/DQMServices/Components/test/TestDQMToolsPlugins/libTestDQMToolsPlugins.so
>> Building edm plugin tmp/slc6_amd64_gcc493/src/DQMServices/FwkIO/plugins/DQMServicesFwkIOPlugins/libDQMServicesFwkIOPlugins.so

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13221/11131/summary.html

@davidlange6
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11142/console

@cmsbuild
Copy link
Contributor

-1
Tested at: 2287fd1
I found an error when building:

@@@@ ----> OK  EDM Class Transients 
Leaving library rule at src/Validation/RecoVertex/bin
>> Leaving Package Validation/RecoVertex
>> Package Validation/RecoVertex built
gmake: Target `all' not remade because of errors.
gmake: **\* [There are compilation/build errors. Please see the detail log above.] Error 2

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13221/11142/summary.html

@makortel
Copy link
Contributor Author

The error seems to be

>> Entering Package DQMServices/ClientConfig
>> copied data-class-funcs.py
>> copied edm-global-class.py
  src/DQMServices/ClientConfig/python -> python/DQMServices/ClientConfig
>> copied run_class_checker.sh
/bin/sh: line 1: 26394 Segmentation fault      /bin/mkdir -p tmp/slc6_amd64_gcc493/src/DQMServices/ClientConfig/src
gmake: *** [tmp/slc6_amd64_gcc493/src/DQMServices/ClientConfig/src/productautocleanup] Error 139

Problem with the test machine or something?

@makortel
Copy link
Contributor Author

Could somebody restart the tests, please?

@davidlange6
Copy link
Contributor

please test

On Feb 15, 2016, at 9:37 AM, Matti Kortelainen notifications@github.com wrote:

Could somebody restart the tests, please?

—
Reply to this email directly or view it on GitHub.

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11207/console

@cmsbuild
Copy link
Contributor

+1
Tested at: 2287fd1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13221/11207/summary.html

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13221/11207/summary.html

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Feb 15, 2016
@cmsbuild
Merge pull request #13221 from makortel/mtvFixTrackingOnlyFastSim
83a2662 
Fix trackingOnly tracking validation for FastSim and Phase1
@cmsbuild cmsbuild merged commit 83a2662 into cms-sw:CMSSW_8_0_X Feb 15, 2016
@makortel makortel deleted the mtvFixTrackingOnlyFastSim branch October 20, 2016 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-available dqm-approved fully-signed orp-approved tests-approved
Projects
None yet
Milestone
CMSSW_8_0_X
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@makortel @cmsbuild @VinInn @deguio @davidlange6