New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configuration parameter copy and modify functions extended #13244
Configuration parameter copy and modify functions extended #13244
Conversation
The `clone` and `Modifier.toModify` methods have been extended to allow further modifications to the parameters after they have been copied. 1) Specify `None` as the value of the parameter will cause the parameter to be removed from the configuration 2) Parameters within embedded PSets can now be modified using a python dict as the value. The keys of the dictionary are the parameter names and the values are the new values to use. The `clone` and `Modifier.toModify` both call the same helper function to do the work of modifying the copied parameters.
The reimplementation of the Modifier accidentally lost the ability to specify a new parameter when doing the modification. This adds that feature back.
A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_8_0_X. It involves the following packages: FWCore/ParameterSet @cmsbuild, @smuzaffar, @Dr15Jones, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
I tested this with #13216 by running |
please test |
+1 |
The tests are being triggered in jenkins. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
Configuration parameter copy and modify functions extended
The test aborted because it timed out |
@Dr15Jones It looks like
|
The
clone
andModifier.toModify
methods have been extended to allow further modifications to the parameters after they have been copied.None
as the value of the parameter will cause the parameter to be removed from the configurationnames and the values are the new values to use.
The
clone
andModifier.toModify
both call the same helper function to do the work of modifying the copied parameters.This also fixed the problem with the previous pull request for this feature.