Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add non triggering electron Loose WP #13265

Merged

Conversation

fcouderc
Copy link
Contributor

same as PR #13263

@ikrav 80X PR

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fcouderc for CMSSW_8_0_X.

It involves the following packages:

RecoEgamma/ElectronIdentification

@cmsbuild, @cvuosalo, @davidlange6, @slava77 can you please review it and eventually sign? Thanks.
@Sam-Harper, @lgray this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@slava77
Copy link
Contributor

slava77 commented Feb 12, 2016

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11161/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented Feb 12, 2016

+1

for #13265 bd586f0

  • changes in the code/configuration are as described: a new electron ID is defined; it is loaded and stored in miniAOD electrons.
  • jenkins tests pass and comparisons with baseline show no differences
    • inspection of the local copy of jenkins miniAOD output in 134.911 shows an increase of electronIDs_ size by 1, as expected

Although this is technically a new feature in a running workflow, it's an addition of an ID flag not affecting already existing logic or validation.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

davidlange6 added a commit that referenced this pull request Feb 12, 2016
…rons_80X

add non triggering electron Loose WP
@davidlange6 davidlange6 merged commit f9468f6 into cms-sw:CMSSW_8_0_X Feb 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants