Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to the new HLT L1T Seeds Module for 2016 (pass2) #13285

Merged

Conversation

mulhearn
Copy link
Contributor

This is a replacement for #13277 after rebasing to latest CMSSW 8_0_X.

Updates the new HLT L1T Seed Module, needed for the 2016, including parsing of object map to determine seeds, low-level object fixes to ensure Trigger Filter Object with References (to L1T seeds) is successfully written to the event record with desired payload. (A number of technical problems with L1T objects were uncovered, and now fixed, when this module attempted to write edm::Ref of L1T BXVectors.)

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mulhearn for CMSSW_8_0_X.

It involves the following packages:

DataFormats/HLTReco
DataFormats/L1Trigger
HLTrigger/HLTcore
HLTrigger/HLTfilters
HLTrigger/Muon
L1Trigger/L1TCommon

@perrotta, @cmsbuild, @Martin-Grunewald, @fwyzard, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @abbiendi, @trocino, @jhgoh, @battibass this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

LogVerbatim("TriggerSummaryAnalyzerRAW") << " L1TEGamma: " << handle->l1tegammaSize() << endl;
LogVerbatim("TriggerSummaryAnalyzerRAW") << " L1TEGamma: " << handle->l1tjetSize() << endl;
LogVerbatim("TriggerSummaryAnalyzerRAW") << " L1TEGamma: " << handle->l1ttauSize() << endl;
LogVerbatim("TriggerSummaryAnalyzerRAW") << " L1TEGamma: " << handle->l1tetsumSize() << endl;
} else {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cut and paste errors in the above three lines.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vladimir fixing now.

@mulhearn
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

Pull request #13285 was updated. @perrotta, @cmsbuild, @Martin-Grunewald, @fwyzard, @mulhearn, @davidlange6 can you please check and sign again.

@cmsbuild
Copy link
Contributor

Pull request #13285 was updated. @perrotta, @cmsbuild, @Martin-Grunewald, @fwyzard, @mulhearn, @davidlange6 can you please check and sign again.

@mulhearn
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11225/console

@cmsbuild
Copy link
Contributor

-1
Tested at: 1632cad
When I ran the RelVals I found an error in the following worklfows:
50202.0 step2

runTheMatrix-results/50202.0_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50/step2_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50.log
----- Begin Fatal Exception 15-Feb-2016 17:35:52 CET-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=MixingModule label='mix'
Exception Message:
RootEmbeddedFileSequence no input files specified for secondary input source.
----- End Fatal Exception -------------------------------------------------

25202.0 step2

runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25/step2_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25.log
----- Begin Fatal Exception 15-Feb-2016 17:37:22 CET-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=MixingModule label='mix'
Exception Message:
RootEmbeddedFileSequence no input files specified for secondary input source.
----- End Fatal Exception -------------------------------------------------

1003.0 step1

DAS Error

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13285/11225/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
c3f353c
839f632
4873653
d4c91a7
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13285/11225/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13285/11225/git-merge-result

@Martin-Grunewald
Copy link
Contributor

please test

(errors unrelated to this PR)

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

Pull request #13285 was updated. @perrotta, @cmsbuild, @Martin-Grunewald, @fwyzard, @mulhearn, @davidlange6 can you please check and sign again.

@Martin-Grunewald
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11252/console

@cmsbuild
Copy link
Contributor

@Martin-Grunewald
Copy link
Contributor

+1

davidlange6 added a commit that referenced this pull request Feb 16, 2016
Updates to the new HLT L1T Seeds Module for 2016 (pass2)
@davidlange6 davidlange6 merged commit 4221a91 into cms-sw:CMSSW_8_0_X Feb 16, 2016
@cmsbuild
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants