New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates to the new HLT L1T Seeds Module for 2016 (pass2) #13285
Updates to the new HLT L1T Seeds Module for 2016 (pass2) #13285
Conversation
A new Pull Request was created by @mulhearn for CMSSW_8_0_X. It involves the following packages: DataFormats/HLTReco @perrotta, @cmsbuild, @Martin-Grunewald, @fwyzard, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
LogVerbatim("TriggerSummaryAnalyzerRAW") << " L1TEGamma: " << handle->l1tegammaSize() << endl; | ||
LogVerbatim("TriggerSummaryAnalyzerRAW") << " L1TEGamma: " << handle->l1tjetSize() << endl; | ||
LogVerbatim("TriggerSummaryAnalyzerRAW") << " L1TEGamma: " << handle->l1ttauSize() << endl; | ||
LogVerbatim("TriggerSummaryAnalyzerRAW") << " L1TEGamma: " << handle->l1tetsumSize() << endl; | ||
} else { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cut and paste errors in the above three lines.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Vladimir fixing now.
please test |
The tests are being triggered in jenkins. |
Pull request #13285 was updated. @perrotta, @cmsbuild, @Martin-Grunewald, @fwyzard, @mulhearn, @davidlange6 can you please check and sign again. |
143514a
to
1632cad
Compare
Pull request #13285 was updated. @perrotta, @cmsbuild, @Martin-Grunewald, @fwyzard, @mulhearn, @davidlange6 can you please check and sign again. |
please test |
The tests are being triggered in jenkins. |
-1 runTheMatrix-results/50202.0_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50/step2_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50.log ----- Begin Fatal Exception 15-Feb-2016 17:35:52 CET----------------------- An exception of category 'Configuration' occurred while [0] Constructing the EventProcessor [1] Constructing module: class=MixingModule label='mix' Exception Message: RootEmbeddedFileSequence no input files specified for secondary input source. ----- End Fatal Exception ------------------------------------------------- 25202.0 step2 runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25/step2_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25.log ----- Begin Fatal Exception 15-Feb-2016 17:37:22 CET----------------------- An exception of category 'Configuration' occurred while [0] Constructing the EventProcessor [1] Constructing module: class=MixingModule label='mix' Exception Message: RootEmbeddedFileSequence no input files specified for secondary input source. ----- End Fatal Exception ------------------------------------------------- 1003.0 step1 DAS Error you can see the results of the tests here: The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
please test (errors unrelated to this PR) |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
Pull request #13285 was updated. @perrotta, @cmsbuild, @Martin-Grunewald, @fwyzard, @mulhearn, @davidlange6 can you please check and sign again. |
please test |
The tests are being triggered in jenkins. |
+1 |
Updates to the new HLT L1T Seeds Module for 2016 (pass2)
This is a replacement for #13277 after rebasing to latest CMSSW 8_0_X.
Updates the new HLT L1T Seed Module, needed for the 2016, including parsing of object map to determine seeds, low-level object fixes to ensure Trigger Filter Object with References (to L1T seeds) is successfully written to the event record with desired payload. (A number of technical problems with L1T objects were uncovered, and now fixed, when this module attempted to write edm::Ref of L1T BXVectors.)