Make the checks and loading of missing dictionaries thread-safe #13291
Conversation
The global missingTypes list was not thread safe and the operations it was used for could not be made safe even with a concurrent container. Therefore all functions which used to manipulate the global list now require a local list be passed as an argument.
Only do the missing dictionary checks and loads in ProductRegistryHelper as items are to be added to the ProductRegistry. This avoids the use of a global list of missing dictionaries which is not thread-safe.
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_8_0_X. It involves the following packages: DataFormats/Provenance @cmsbuild, @smuzaffar, @Dr15Jones, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
|
please test |
|
The tests are being triggered in jenkins. |
|
-1 Tested at: f109713 ---> test testRecoMETMETProducers had ERRORS you can see the results of the tests here: |
|
the test failures are not caused by this pull request |
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (but tests are reportedly failing). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
cmsbuild
added
core-approved
fully-signed
and removed
core-pending
pending-signatures
labels
Make the checks and loading of missing dictionaries thread-safe
Removed the use of a non-thread-safe global list of missing dictionaries. Now centralized checking and loading missing dictionaries to allow only a local list of missing dictionaries.