Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to cope with changed interface on pythia side #13305

Merged
merged 1 commit into from Feb 23, 2016

Conversation

bendavid
Copy link
Contributor

Needs to be taken together with
cms-sw/cmsdist#2131

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @bendavid (Josh Bendavid) for CMSSW_8_0_X.

It involves the following packages:

GeneratorInterface/Pythia8Interface

@vciulli, @covarell, @thuer, @cmsbuild, @bendavid, @davidlange6, @govoni can you please review it and eventually sign? Thanks.
@mkirsano this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@covarell
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11251/console

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

-1
Tested at: 1bfa1e7
I found an error when building:

@@@@ Running edmWriteConfigs for ZJetsTestAnalyzer
>> Building shared library tmp/slc6_amd64_gcc493/src/GeneratorInterface/Pythia8Interface/src/GeneratorInterfacePythia8Interface/libGeneratorInterfacePythia8Interface.so
Copying tmp/slc6_amd64_gcc493/src/GeneratorInterface/Pythia8Interface/src/GeneratorInterfacePythia8Interface/libGeneratorInterfacePythia8Interface.so to productstore area:
Leaving library rule at GeneratorInterface/Pythia8Interface
/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_0_X_2016-02-15-2300/src/GeneratorInterface/Pythia8Interface/plugins/Pythia8Hadronizer.cc: In member function 'bool Pythia8Hadronizer::hadronize()':
/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_0_X_2016-02-15-2300/src/GeneratorInterface/Pythia8Interface/plugins/Pythia8Hadronizer.cc:610:71: error: 'class Pythia8::JetMatchingMadgraph' has no member named 'getDJR'
     const std::vector djrmatch = fJetMatchingPy8InternalHook->getDJR();
                                                                       ^
--- Registered EDM Plugin: ZJetsTestAnalyzer
>> Building edm plugin tmp/slc6_amd64_gcc493/src/GeneratorInterface/Pythia8Interface/plugins/GeneratorInterfacePythia8Guns/libGeneratorInterfacePythia8Guns.so
Leaving library rule at src/GeneratorInterface/Pythia8Interface/plugins


you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13305/11251/summary.html

@bendavid
Copy link
Contributor Author

Errors are of course because it must be taken together with cms-sw/cmsdist#2131

@ghost
Copy link

ghost commented Feb 17, 2016

please test with cms-sw/cmsdist#2131

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
Using externals from cms-sw/cmsdist#2131
https://cmssdt.cern.ch/jenkins/job/cmsdist-cmssw-test-pr/20/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

davidlange6 added a commit that referenced this pull request Feb 23, 2016
update to cope with changed interface on pythia side
@davidlange6 davidlange6 merged commit 375c28b into cms-sw:CMSSW_8_0_X Feb 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants