Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add const-correct physical-value-only EtSumHelper and L1T demo #13319

Merged
merged 1 commit into from Feb 17, 2016

Conversation

mulhearn
Copy link
Contributor

This PR replaces #13312.

This is for downstream consumers of the L1T output. A Helper class for interpreting somewhat confusing new format for the L1T EtSums is provided, along with demonstration code for all of L1T upgrade objects.

This version is const-correct and only accesses physical ET values.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mulhearn for CMSSW_8_0_X.

It involves the following packages:

DataFormats/L1Trigger
L1Trigger/L1TCommon

@cmsbuild, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@mulhearn
Copy link
Contributor Author

please test

@mulhearn
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11270/console

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

davidlange6 added a commit that referenced this pull request Feb 17, 2016
Add const-correct physical-value-only EtSumHelper and L1T demo
@davidlange6 davidlange6 merged commit 309a066 into cms-sw:CMSSW_8_0_X Feb 17, 2016
@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants