Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MET PAT tool update + update of MET significance #13372

Merged
merged 38 commits into from Mar 10, 2016

Conversation

cmsbuild
Copy link
Contributor

This PR contains the following changes :

  • fix several tiny bugs in the MET tool (e.g. JECs were not properly propagated when only reapplied on slimmed jets, met significance set to zero arbitrary in the wrong constructor)
  • revisits the jet smearing code
  • enable the jet smearing and its propagation to the MET
  • revisits the MET unclustered energy uncertainties with detector based resolution instead of the ad-hoc 10%
  • uniformize the jet selection for Type1MET correction and MET JES uncertainties
  • enable the use of DB JER numbers for teh MET significance and jet smearing
  • fix the scheduled mode of the PAT MET tool

======= /!\ IMPORTANT NOTICE /!\ =========

Jet energy resolution values are now available in the database, but not yet stored in it. and those values are used in the jet smearing and in the met significance computation. In the lack of GT containing a JetResolutionRcd entry, all tests (runTheMatrix or standard tests) involving a PAT process will fail if it touches the MET tool.

Packages involved :

  • DataFormats/METReco
  • DataFormats/PatCandidates
  • JetMETCorrections/Modules
  • JetMETCorrections/Type1MET
  • PhysicsTools/PatAlgos
  • PhysicsTools/PatUtils
  • RecoMET/METAlgorithms
  • RecoMET/METProducers

Changes expected :

  • very tiny change in CPU consumption due the MET significance computation
  • MET significance is now computed in the central pat::MET
  • tiny change expected in the slimmedMET/ patPFMetType1 pT values due to the uniformization of cleaning (removal of overlaps selected/slimmed muons and electrons)
  • unclustered uncertainties changed
  • smeared MET not set to the central value anymore
  • JER uncertainties accessible if someone uses the smeared MET
    Automatically ported from CMSSW_8_0_X MET PAT tool update + update of MET significance #13115 (original by @cms-met).

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Mar 9, 2016

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Mar 9, 2016

@cmsbuild
Copy link
Contributor Author

Pull request #13372 was updated. @cvuosalo, @monttj, @cmsbuild, @slava77, @vadler, @davidlange6 can you please check and sign again.

@slava77
Copy link
Contributor

slava77 commented Mar 10, 2016

@cmsbuild please test

@cmsbuild
Copy link
Contributor Author

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11812/console

@cmsbuild
Copy link
Contributor Author

@cmsbuild
Copy link
Contributor Author

@slava77
Copy link
Contributor

slava77 commented Mar 10, 2016

+1

for #13372 1f1c606

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants