Extending HCAL unpacking to uTCA HBHE FEDs #13389

abdoulline · 2016-02-18T12:57:11Z

Late (alas...) step in preparations for MWGR#2:

(1) Emap submitted to AlCaDB validation
https://hypernews.cern.ch/HyperNews/CMS/get/calibrations/2228.html

(2) this small unpacker update needs 800 patch, if possible

cmsbuild · 2016-02-18T12:57:31Z

A new Pull Request was created by @abdoulline (Salavat Abdullin) for CMSSW_8_0_X.

It involves the following packages:

EventFilter/HcalRawToDigi

@cmsbuild, @cvuosalo, @davidlange6, @slava77 can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

slava77 · 2016-02-18T14:21:33Z

EventFilter/HcalRawToDigi/plugins/HcalRawToDigi.cc

@@ -37,6 +37,16 @@ HcalRawToDigi::HcalRawToDigi(edm::ParameterSet const& conf):
    fedUnpackList_.push_back(1118);
    fedUnpackList_.push_back(1120);
    fedUnpackList_.push_back(1122);
+    // HBHE uTCA


can we instead of this change to a loop from MINHCALuTCAFEDID to MAXHCALuTCAFEDID ?
that's from 1100 to 1199.
The only reason not to would be that you'd expect the FEDs not listed here already to come and go and produce corrupt data.

Those explicitly listed are certainly what we need.
Let me clarify it with HCAL OPS guys whether there could be some
unnecessary "extra" FEDs still connected (presumably no)

On Thu, 18 Feb 2016, Slava Krutelyov wrote:

In EventFilter/HcalRawToDigi/plugins/HcalRawToDigi.cc:

@@ -37,6 +37,16 @@ HcalRawToDigi::HcalRawToDigi(edm::ParameterSet const& conf):
fedUnpackList_.push_back(1118);
fedUnpackList_.push_back(1120);
fedUnpackList_.push_back(1122);

// HBHE uTCA

can we instead of this change to a loop from MINHCALuTCAFEDID to MAXHCALuTCAFEDID ?
that's from 1100 to 1199.
The only reason not to would be that you'd expect the FEDs not listed here already to come and go and produce corrupt
data.

—
Reply to this email directly or view it on GitHub.[AEx02iVbeFXR0hFWg0luflN0Hz6WF_7Yks5plcrwgaJpZM4HdCHO.gif]

making this inclusive loop will

prevent these unpacker changes (apparently forgotten until the last minute)

get rid of the hardcoded FED numbers (FedNumbering is preferred)

abdoulline · 2016-02-18T15:01:34Z

Slava, I still prefer to keep FEDs list in two parts separately (VME + uTCA).
Viktor Khristenko
@vkhristenko
will hopefully give it a try with a new emap tomorrow.

slava77 · 2016-02-18T15:18:36Z

@cmsbuild please test

cmsbuild · 2016-02-18T15:18:53Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11348/console

cmsbuild · 2016-02-18T18:30:00Z

+1
Tested at: fa80a0e
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13389/11348/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
ecdb8f5
aa97d14
3a229d9
66fa865
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13389/11348/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13389/11348/git-merge-result

slava77 · 2016-02-18T21:16:42Z

... comparisons got stuck and the new IB is somewhat broken.
I'll test locally.

slava77 · 2016-02-19T05:26:42Z

@cmsbuild please test

cmsbuild · 2016-02-19T05:26:58Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11367/console
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11387/console

slava77 · 2016-02-19T05:43:27Z

+1

for #13389 fa80a0e

code changes are in line with the description
jenkins tests passed runtime and compilation
tested locally in CMSSW_8_0_0 with an equivalent of the matrix tests (more events, actually) as the ones checked in jenkins. There are no changes in monitored quentities.

belatedly, this has to go to T0 and online ASAP, to match the needs for MWGR2 for HCAL (tests of uTCA readout of HE .. or is it HB as well?)

cmsbuild · 2016-02-19T05:43:45Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

abdoulline · 2016-02-19T06:42:09Z

We have now both HB and HE moved to uTCA electronics (as reflected in

aforementioned emap and the relevant FEDs included in this minimal unpacker
update).
NB: current tests use current (still VME for HB/HE) emap, so what happens
now with this PR activated: uTCA FEDs are unpacked (good) but Digi from
them aren't produced. They are produced still from (still present in
RAW) VME HB/HE FEDs.

But we're going now to make additional private tests to make sure
explicitly that this combination/tandem of this PR + new emap works OK.
Well, there were already some tests ofuTCA HBHE FEDs unpacking
(cherrypicking) proved to be OK.

On Fri, 19 Feb 2016, Slava Krutelyov wrote:

+1

for #13389 fa80a0e

code changes are in line with the description

jenkins tests passed runtime and compilation

tested locally in CMSSW_8_0_0 with an equivalent of the matrix tests (more events, actually) as the ones checked in
jenkins. There are no changes in monitored quentities.

belatedly, this has to go to T0 and online ASAP, to match the needs for MWGR2 for HCAL (tests of uTCA readout of HE .. or
is it HB as well?)

—
Reply to this email directly or view it on GitHub.[AEx02lh1bsJNYAC8EtF_okKlmnmbGHfxks5plqMCgaJpZM4HdCHO.gif]

slava77 · 2016-02-19T06:55:35Z

Salavat,

In case you have a reference file with HB/HE taken from uTCA and a new emap,
it would be useful to have as a reference.

Thanks

On 2/18/16 10:42 PM, Salavat Abdullin wrote:

We have now both HB and HE moved to uTCA electronics (as reflected in
aforementioned emap and the relevant FEDs included in this minimal unpacker
update).
NB: current tests use current (still VME for HB/HE) emap, so what happens
now with this PR activated: uTCA FEDs are unpacked (good) but Digi from
them aren't produced. They are produced still from (still present in
RAW) VME HB/HE FEDs.

But we're going now to make additional private tests to make sure
explicitly that this combination/tandem of this PR + new emap works OK.
Well, there were already some tests ofuTCA HBHE FEDs unpacking
(cherrypicking) proved to be OK.

On Fri, 19 Feb 2016, Slava Krutelyov wrote:

+1

for #13389 fa80a0e

code changes are in line with the description

jenkins tests passed runtime and compilation

tested locally in CMSSW_8_0_0 with an equivalent of the matrix tests (more events, actually) as the ones checked in
jenkins. There are no changes in monitored quentities.

belatedly, this has to go to T0 and online ASAP, to match the needs for MWGR2 for HCAL (tests of uTCA readout of HE .. or
is it HB as well?)

—
Reply to this email directly or view it on GitHub.[AEx02lh1bsJNYAC8EtF_okKlmnmbGHfxks5plqMCgaJpZM4HdCHO.gif]

—
Reply to this email directly or view it on GitHub
#13389 (comment).

Vyacheslav (Slava) Krutelyov
UCSD: 9500 Gillman Dr, Physics UCSD 0354, La Jolla, CA 92093-0354
CERN: 42-R-027
AIM/Skype: siava16 googleTalk: slava77@gmail.com
(630) 291-5128 Cell (US) +41 76 275 7116 Cell (CERN)

abdoulline · 2016-02-19T07:02:00Z

Slava,

Viktor has kindly agreed to make a test from scratch today:
to use explicitly new emap tag (not txt emap input as before) + this PR
(encompassing all the uTCA FEDs and not cherrypicking uTCA FEDs as before)

NB: uTCA HBHE data is in RAW since quite a while.

On Fri, 19 Feb 2016, Slava Krutelyov wrote:

Salavat,

In case you have a reference file with HB/HE taken from uTCA and a new emap,
it would be useful to have as a reference.

Thanks

On 2/18/16 10:42 PM, Salavat Abdullin wrote:

We have now both HB and HE moved to uTCA electronics (as reflected in
aforementioned emap and the relevant FEDs included in this minimal unpacker
update).
NB: current tests use current (still VME for HB/HE) emap, so what happens
now with this PR activated: uTCA FEDs are unpacked (good) but Digi from
them aren't produced. They are produced still from (still present in
RAW) VME HB/HE FEDs.

But we're going now to make additional private tests to make sure
explicitly that this combination/tandem of this PR + new emap works OK.
Well, there were already some tests ofuTCA HBHE FEDs unpacking
(cherrypicking) proved to be OK.

On Fri, 19 Feb 2016, Slava Krutelyov wrote:

+1

for #13389 fa80a0e

code changes are in line with the description

jenkins tests passed runtime and compilation

tested locally in CMSSW_8_0_0 with an equivalent of the matrix tests (more events, actually) as the ones checked in
jenkins. There are no changes in monitored quentities.

belatedly, this has to go to T0 and online ASAP, to match the needs for MWGR2 for HCAL (tests of uTCA readout of HE ..
or
is it HB as well?)

—
Reply to this email directly or view it on GitHub.[AEx02lh1bsJNYAC8EtF_okKlmnmbGHfxks5plqMCgaJpZM4HdCHO.gif]

—
Reply to this email directly or view it on GitHub
#13389 (comment).

Vyacheslav (Slava) Krutelyov
UCSD: 9500 Gillman Dr, Physics UCSD 0354, La Jolla, CA 92093-0354
CERN: 42-R-027
AIM/Skype: siava16 googleTalk: slava77@gmail.com
(630) 291-5128 Cell (US) +41 76 275 7116 Cell (CERN)

—
Reply to this email directly or view it on GitHub.[AEx02mEcQupRN9FpIutF0ZfpLViarwHpks5plrPqgaJpZM4HdCHO.gif]

cmsbuild · 2016-02-19T07:31:05Z

+1
Tested at: fa80a0e
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13389/11367/summary.html

cmsbuild · 2016-02-19T12:14:49Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13389/11367/summary.html

cmsbuild · 2016-02-19T12:33:36Z

+1
Tested at: fa80a0e
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13389/11387/summary.html

cmsbuild · 2016-02-19T13:34:26Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13389/11387/summary.html

smuzaffar · 2016-02-19T13:39:36Z

@davidlange6, the last tests for this PR were run based on slc6_amd64_gcc530 IB and comparison were made using slc6_amd64_gcc493 baseline.

slava77 · 2016-02-19T14:04:31Z

So, there are small differences in tracking outputs between slc6_amd64_gcc530 and slc6_amd64_gcc493 based on these /11387/ diffs
#13389 (comment)
We may want to keep this in a better location than a side PR

davidlange6 · 2016-02-19T14:19:38Z

Right - I think from this we can schedule relvals and switchover. I need to look more carefully, but I did not find anything to worry about yet.

On Feb 19, 2016, at 3:04 PM, Slava Krutelyov notifications@github.com wrote:

So, there are small differences in tracking outputs between slc6_amd64_gcc530 and slc6_amd64_gcc493 based on these /11387/ diffs
#13389 (comment)
We may want to keep this in a better location than a side PR

—
Reply to this email directly or view it on GitHub.

Extending HCAL unpacking to uTCA HBHE FEDs

Extending HCAL unpacking to uTCA HBHE FEDs

c553367

cmsbuild added this to the Next CMSSW_8_0_X milestone Feb 18, 2016

cmsbuild added reconstruction-pending pending-signatures tests-pending orp-pending comparison-pending labels Feb 18, 2016

slava77 reviewed Feb 18, 2016
View reviewed changes

using FEDNumbering DataFormat enum for uTCA HBHE FEDs

fa80a0e

cmsbuild added tests-started and removed tests-pending labels Feb 18, 2016

cmsbuild added tests-approved and removed tests-started labels Feb 18, 2016

cmsbuild added tests-pending tests-started and removed tests-approved tests-pending labels Feb 19, 2016

cmsbuild added reconstruction-approved fully-signed and removed pending-signatures reconstruction-pending labels Feb 19, 2016

cmsbuild added tests-approved and removed tests-started labels Feb 19, 2016

cmsbuild added comparison-available and removed comparison-pending labels Feb 19, 2016

davidlange6 added a commit that referenced this pull request Feb 19, 2016

Merge pull request #13389 from abdoulline/uTCA_HBHE_FEDs

aac9004

Extending HCAL unpacking to uTCA HBHE FEDs

davidlange6 merged commit aac9004 into cms-sw:CMSSW_8_0_X Feb 19, 2016

abdoulline deleted the uTCA_HBHE_FEDs branch April 13, 2017 11:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Extending HCAL unpacking to uTCA HBHE FEDs #13389

Extending HCAL unpacking to uTCA HBHE FEDs #13389

abdoulline commented Feb 18, 2016

cmsbuild commented Feb 18, 2016

slava77 Feb 18, 2016

abdoulline Feb 18, 2016

slava77 Feb 18, 2016

abdoulline commented Feb 18, 2016

slava77 commented Feb 18, 2016

cmsbuild commented Feb 18, 2016

cmsbuild commented Feb 18, 2016

slava77 commented Feb 18, 2016

slava77 commented Feb 19, 2016

cmsbuild commented Feb 19, 2016

slava77 commented Feb 19, 2016

cmsbuild commented Feb 19, 2016

abdoulline commented Feb 19, 2016

slava77 commented Feb 19, 2016

abdoulline commented Feb 19, 2016

cmsbuild commented Feb 19, 2016

cmsbuild commented Feb 19, 2016

cmsbuild commented Feb 19, 2016

cmsbuild commented Feb 19, 2016

smuzaffar commented Feb 19, 2016

slava77 commented Feb 19, 2016

davidlange6 commented Feb 19, 2016

Extending HCAL unpacking to uTCA HBHE FEDs #13389

Extending HCAL unpacking to uTCA HBHE FEDs #13389

Conversation

abdoulline commented Feb 18, 2016

cmsbuild commented Feb 18, 2016

slava77 Feb 18, 2016

Choose a reason for hiding this comment

abdoulline Feb 18, 2016

Choose a reason for hiding this comment

slava77 Feb 18, 2016

Choose a reason for hiding this comment

abdoulline commented Feb 18, 2016

slava77 commented Feb 18, 2016

cmsbuild commented Feb 18, 2016

cmsbuild commented Feb 18, 2016

slava77 commented Feb 18, 2016

slava77 commented Feb 19, 2016

cmsbuild commented Feb 19, 2016

slava77 commented Feb 19, 2016

cmsbuild commented Feb 19, 2016

abdoulline commented Feb 19, 2016

slava77 commented Feb 19, 2016

abdoulline commented Feb 19, 2016

cmsbuild commented Feb 19, 2016

cmsbuild commented Feb 19, 2016

cmsbuild commented Feb 19, 2016

cmsbuild commented Feb 19, 2016

smuzaffar commented Feb 19, 2016

slava77 commented Feb 19, 2016

davidlange6 commented Feb 19, 2016