Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DQM TrackerMonitorTrack improvements (80X version) #13404

Merged

Conversation

schneiml
Copy link
Contributor

This PR adds a number of changes on top of #13240. See also #13393

  • Location and naming of the residual histograms for SiPixel is improved
  • Cuts on pT and dxy significance are applied for all residuals. Such cuts were missing in the original SiStrip version. The histograms are now closer to the old SiPixel residuals histograms.
  • The source code now compiles into two modules to keep the configrations of SiPixel and SiStrip independent.
  • Some other cleanup.

These changes affect the configuration options for the TrackMonitorTrack module. I updated the config files as far as I could follow; however, the new SiPixelMonitorTrackResiduals might be added in more places. Also, some files use options that were probably broken before, i did not touch these.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @schneiml (Marcel Schneider) for CMSSW_8_0_X.

It involves the following packages:

Alignment/OfflineValidation
DQM/SiPixelCommon
DQM/SiStripMonitorClient
DQM/TrackerMonitorTrack

@diguida, @cerminar, @cmsbuild, @franzoni, @deguio, @mmusich, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @makortel, @tocheng, @tlampen, @mschrode, @mmusich, @threus, @venturia this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@mmusich
Copy link
Contributor

mmusich commented Feb 19, 2016

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11380/console

@cmsbuild
Copy link
Contributor

@mmusich
Copy link
Contributor

mmusich commented Feb 19, 2016

+1
for schneiml@9bca63f
changes in AlCa package (Alignment/OfflineValidation) are in line with code description:

  • remove unnecessary interface fillHitQuantities from Alignment/OfflineValidation/interface/TrackerValidationVariables.h
  • added filter functionality in fillTrackQuantities method of same class, to allow cuts on pT and dxy significance. Filter is always passed when running the standalone Tracker Alignment offline validation suite.

@cmsbuild
Copy link
Contributor

Pull request #13404 was updated. @diguida, @cerminar, @cmsbuild, @franzoni, @deguio, @mmusich, @vanbesien, @davidlange6 can you please check and sign again.

@schneiml schneiml force-pushed the dqm-tracker-residuals-improvements branch from 5ed69b9 to 3fccd1a Compare March 10, 2016 13:13
@cmsbuild
Copy link
Contributor

Pull request #13404 was updated. @diguida, @cerminar, @cmsbuild, @franzoni, @deguio, @mmusich, @vanbesien, @davidlange6 can you please check and sign again.

@mmusich
Copy link
Contributor

mmusich commented Mar 10, 2016

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11817/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@mmusich
Copy link
Contributor

mmusich commented Mar 11, 2016

+1

@deguio
Copy link
Contributor

deguio commented Mar 15, 2016

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Mar 17, 2016
…ments

DQM TrackerMonitorTrack improvements (80X version)
@cmsbuild cmsbuild merged commit 5437ff7 into cms-sw:CMSSW_8_0_X Mar 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants