Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AssociationMap in TrackRefitter (81X) #13446

Merged
merged 3 commits into from Feb 26, 2016
Merged

Fix AssociationMap in TrackRefitter (81X) #13446

merged 3 commits into from Feb 26, 2016

Conversation

aysent
Copy link
Contributor

@aysent aysent commented Feb 24, 2016

Same as #13445, but for 81X.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @aysent (Aysen Tatarinov) for CMSSW_8_1_X.

It involves the following packages:

TrackingTools/TrackRefitter

@cmsbuild, @cvuosalo, @davidlange6, @slava77 can you please review it and eventually sign? Thanks.
@battibass, @makortel, @abbiendi, @GiacomoSguazzoni, @jhgoh, @VinInn, @bellan, @rovere, @istaslis, @gpetruc, @cerati, @trocino, @dgulhan this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@slava77
Copy link
Contributor

slava77 commented Feb 24, 2016

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11489/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Pull request #13446 was updated. @cmsbuild, @cvuosalo, @davidlange6, @slava77 can you please check and sign again.

@cmsbuild
Copy link
Contributor

Pull request #13446 was updated. @cmsbuild, @cvuosalo, @davidlange6, @slava77 can you please check and sign again.

@cvuosalo
Copy link
Contributor

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11510/console

@cmsbuild
Copy link
Contributor

@cvuosalo
Copy link
Contributor

@cmsbuild please test
Comparisons got stuck in Queued state

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11537/console

@cmsbuild
Copy link
Contributor

-1
Tested at: 8441d53
When I ran the RelVals I found an error in the following worklfows:
5.1 step1

runTheMatrix-results/5.1_TTbar+TTbarFS+HARVESTFS/step1_TTbar+TTbarFS+HARVESTFS.log

135.4 step1

runTheMatrix-results/135.4_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS/step1_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS.log

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13446/11537/summary.html

@cmsbuild
Copy link
Contributor

@cvuosalo
Copy link
Contributor

+1

For #13446 8441d53

Small fix for track-trajectory map in track refitter. There should be no change in monitored quantities.
#13445 is the 80X version of this PR, and it has already been approved by Reco.

The code change is satisfactory, and Jenkins tests against baseline CMSSW_8_1_X_2016-02-23-2300 show no significant differences, as expected. Note Jenkins test 11510 succeeded after about 24 hours, but the subsequent Jenkins test ran into errors not related to this PR, so the latter test should be ignored.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (but tests are reportedly failing). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

davidlange6 added a commit that referenced this pull request Feb 26, 2016
Fix AssociationMap in TrackRefitter (81X)
@davidlange6 davidlange6 merged commit 27540e7 into cms-sw:CMSSW_8_1_X Feb 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants