Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct raw data collection to be used #13487

Merged
merged 1 commit into from Mar 1, 2016
Merged

correct raw data collection to be used #13487

merged 1 commit into from Mar 1, 2016

Conversation

fioriNTU
Copy link
Contributor

No description provided.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fioriNTU for CMSSW_8_0_X.

It involves the following packages:

CalibTracker/SiStripCommon

@diguida, @cerminar, @cmsbuild, @franzoni, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks.
@jlagram, @gbenelli, @tocheng this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@mmusich
Copy link
Contributor

mmusich commented Feb 26, 2016

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11567/console

@deguio
Copy link
Contributor

deguio commented Feb 26, 2016

please test

@cmsbuild
Copy link
Contributor

@mmusich
Copy link
Contributor

mmusich commented Feb 26, 2016

@deguio what is the context of this one?

@deguio
Copy link
Contributor

deguio commented Mar 1, 2016

several sistrip plots are empty if the detector is only partially on. this is due to the wrong usage of the dcs bits from the event.

@fioriNTU could add more details if needed.

@fioriNTU
Copy link
Contributor Author

fioriNTU commented Mar 1, 2016

@mmusich basically before this fix (probably also in Run I) the DQM code couldn't check if a partition was in DAQ or not, and the DQM plots are filtered requiring that a partition in HV OFF state should be OUT of DAQ. In this case the TEC- was HV OFF and (for the DQM code) IN DAQ, situation that simply stops any DQM processing. This fix anyway is relevant only if an entire partition of the Tracker is HV OFF, very rare situation.

davidlange6 added a commit that referenced this pull request Mar 1, 2016
correct raw data collection to be used
@davidlange6 davidlange6 merged commit c759cab into cms-sw:CMSSW_8_0_X Mar 1, 2016
@mmusich
Copy link
Contributor

mmusich commented Mar 2, 2016

+1
for the record

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 2, 2016

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants