Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix memory leaks in EcalClusterLazyTools #13504

Merged
merged 7 commits into from
Mar 8, 2016

Conversation

jolange
Copy link
Contributor

@jolange jolange commented Feb 26, 2016

see #13497

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @jolange (Johannes Lange) for CMSSW_8_0_X.

It involves the following packages:

RecoEcal/EgammaCoreTools

@cmsbuild, @cvuosalo, @davidlange6, @slava77 can you please review it and eventually sign? Thanks.
@Sam-Harper, @argiro, @lgray this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@slava77
Copy link
Contributor

slava77 commented Feb 26, 2016

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11585/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 2, 2016

Pull request #13504 was updated. @cmsbuild, @cvuosalo, @davidlange6, @slava77 can you please check and sign again.

@cvuosalo
Copy link
Contributor

cvuosalo commented Mar 2, 2016

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 2, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11673/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2016

Pull request #13504 was updated. @cmsbuild, @cvuosalo, @davidlange6, @slava77 can you please check and sign again.

@cvuosalo
Copy link
Contributor

cvuosalo commented Mar 7, 2016

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11766/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2016

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2016

@cvuosalo
Copy link
Contributor

cvuosalo commented Mar 8, 2016

+1

For #13504 7ea1052

Fixing a memory leak in EcalClusterLazyToolsBase. There should be no change in monitored quantities. #13497 and #13505 are the 76X and 81X versions of this PR, and the former has already been approved.

The code fix is satisfactory, and Jenkins tests against baseline CMSSW_8_0_X_2016-03-06-1100 show no significant differences, as expected.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2016

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Mar 8, 2016
fix memory leaks in EcalClusterLazyTools
@cmsbuild cmsbuild merged commit 5f0f0e4 into cms-sw:CMSSW_8_0_X Mar 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants