Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "withTopo" issue #13567

Merged

Conversation

lihux25
Copy link
Contributor

@lihux25 lihux25 commented Mar 3, 2016

A simple fix to an error that happens when we try to create SQLite files for Channel Quality tags.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 3, 2016

A new Pull Request was created by @lihux25 (Hongxuan Liu) for CMSSW_8_1_X.

It involves the following packages:

CalibCalorimetry/HcalPlugins

@diguida, @cerminar, @cmsbuild, @franzoni, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks.
@tocheng this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@lihux25 lihux25 mentioned this pull request Mar 3, 2016
@mmusich
Copy link
Contributor

mmusich commented Mar 3, 2016

please test

@mmusich
Copy link
Contributor

mmusich commented Mar 3, 2016

+1
provided jenkins agrees

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 3, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11687/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 3, 2016

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 3, 2016

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 3, 2016

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Mar 8, 2016
@cmsbuild cmsbuild merged commit cb64256 into cms-sw:CMSSW_8_1_X Mar 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants