Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protect default PAT jet configuration (81X) #13606

Conversation

ferencek
Copy link
Contributor

@ferencek ferencek commented Mar 4, 2016

This PR addresses the problem reported in https://hypernews.cern.ch/HyperNews/CMS/get/edmFramework/3631.html by protecting the default PAT jet configuration from being modified inadvertently.

Update (Mar. 10, 2016): Rebased to CMSSW_8_1_X_2016-03-10-1100 with

process.patJetsPuppi.userData.userInts.src = cms.VInputTag(cms.InputTag(""))

(introduced in #13642 but now redundant) removed from PhysicsTools/PatAlgos/python/slimming/miniAOD_tools.py.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 4, 2016

A new Pull Request was created by @ferencek (Dinko Ferenček) for CMSSW_8_1_X.

It involves the following packages:

PhysicsTools/PatAlgos

@cvuosalo, @monttj, @cmsbuild, @slava77, @vadler, @davidlange6 can you please review it and eventually sign? Thanks.
@TaiSakuma, @imarches, @ahinzmann, @acaudron, @mmarionncern, @rappoccio, @jdolen, @nhanvtran, @schoef, @ferencek, @gpetruc, @mariadalfonso, @pvmulder this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@slava77
Copy link
Contributor

slava77 commented Mar 5, 2016

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11725/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2016

@cvuosalo
Copy link
Contributor

cvuosalo commented Mar 9, 2016

+1

For #13606 092b178

Protecting PAT jet configuration from undesired modification.

#13605 is the 80X version of this PR, and it has already been approved by Reco.

The code change is satisfactory, and Jenkins tests against baseline CMSSW_8_1_X_2016-03-03-1100 show no significant differences, as expected, except for the differences caused by the additional PRs Jenkins included in the tests. Additional checks were performed for #13605, and they showed the expected results.

@ferencek
Copy link
Contributor Author

ferencek commented Mar 9, 2016

Except there is now a merge conflict after #13642 got merged. Will rebase to fix the conflict.

@ahinzmann
Copy link
Contributor

@ferencek I think now you'll have to undo the line I put in here (I was going to do it in my PR after this one gets merged, but now it is the other way round):
https://github.com/cms-sw/cmssw/pull/13642/files#diff-76dede28e7751d7bb6c5c9542de4155cR254

@ferencek
Copy link
Contributor Author

@ahinzmann, yes, I was planning to do that. Thanks for the reminder.

@ferencek ferencek force-pushed the ProtectPATJetDefaults_from-CMSSW_8_1_X_2016-03-04-2300 branch from 092b178 to 0b0c65a Compare March 10, 2016 12:14
@cmsbuild
Copy link
Contributor

Pull request #13606 was updated. @cvuosalo, @monttj, @cmsbuild, @slava77, @vadler, @davidlange6 can you please check and sign again.

@slava77
Copy link
Contributor

slava77 commented Mar 10, 2016

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11820/console

@cmsbuild
Copy link
Contributor

@cvuosalo
Copy link
Contributor

+1

For #13606 0b0c65a

Second approval after rebase.

New Jenkins tests are OK, though they have differences caused by the other PRs included in the tests.

davidlange6 added a commit that referenced this pull request Mar 14, 2016
…SSW_8_1_X_2016-03-04-2300

Protect default PAT jet configuration (81X)
@davidlange6 davidlange6 merged commit 00d75e5 into cms-sw:CMSSW_8_1_X Mar 14, 2016
@ferencek ferencek deleted the ProtectPATJetDefaults_from-CMSSW_8_1_X_2016-03-04-2300 branch March 15, 2016 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants