New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Protect default PAT jet configuration (81X) #13606
Protect default PAT jet configuration (81X) #13606
Conversation
A new Pull Request was created by @ferencek (Dinko Ferenček) for CMSSW_8_1_X. It involves the following packages: PhysicsTools/PatAlgos @cvuosalo, @monttj, @cmsbuild, @slava77, @vadler, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
@cmsbuild please test |
The tests are being triggered in jenkins. |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
+1 Protecting PAT jet configuration from undesired modification. #13605 is the 80X version of this PR, and it has already been approved by Reco. The code change is satisfactory, and Jenkins tests against baseline CMSSW_8_1_X_2016-03-03-1100 show no significant differences, as expected, except for the differences caused by the additional PRs Jenkins included in the tests. Additional checks were performed for #13605, and they showed the expected results. |
Except there is now a merge conflict after #13642 got merged. Will rebase to fix the conflict. |
@ferencek I think now you'll have to undo the line I put in here (I was going to do it in my PR after this one gets merged, but now it is the other way round): |
@ahinzmann, yes, I was planning to do that. Thanks for the reminder. |
092b178
to
0b0c65a
Compare
@cmsbuild please test |
The tests are being triggered in jenkins. |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
…SSW_8_1_X_2016-03-04-2300 Protect default PAT jet configuration (81X)
This PR addresses the problem reported in https://hypernews.cern.ch/HyperNews/CMS/get/edmFramework/3631.html by protecting the default PAT jet configuration from being modified inadvertently.
Update (Mar. 10, 2016): Rebased to CMSSW_8_1_X_2016-03-10-1100 with
(introduced in #13642 but now redundant) removed from
PhysicsTools/PatAlgos/python/slimming/miniAOD_tools.py
.