Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Top dqm singletopbtagfix #13665

Merged
merged 2 commits into from Mar 24, 2016
Merged

Top dqm singletopbtagfix #13665

merged 2 commits into from Mar 24, 2016

Conversation

bbilin
Copy link
Contributor

@bbilin bbilin commented Mar 9, 2016

fix a bug for wrong b-tag usage in SingleTopTChannelLeptonDQM.cc which was causing empty plots

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 9, 2016

A new Pull Request was created by @PARGALI (Bugra Bilin) for CMSSW_8_1_X.

It involves the following packages:

DQM/Physics

@cmsbuild, @vanbesien, @deguio, @davidlange6 can you please review it and eventually sign? Thanks.
@rappoccio this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@davidlt
Copy link
Contributor

davidlt commented Mar 9, 2016

Can you squash the commits into a single one?

@bbilin
Copy link
Contributor Author

bbilin commented Mar 9, 2016

how shall I do that? Do you want me to make another pull request with one step?

@davidlt
Copy link
Contributor

davidlt commented Mar 9, 2016

git rebase -i official-cmssw/CMSSW_8_1_X then push force to the same branch.

@bbilin
Copy link
Contributor Author

bbilin commented Mar 9, 2016

This is what I get:
git rebase -i official-cmssw/CMSSW_8_1_X
Working tree is dirty

@davidlt
Copy link
Contributor

davidlt commented Mar 9, 2016

You might have additional uncommitted changes in the branch, it has to clean before you rebase.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 9, 2016

Pull request #13665 was updated. @cmsbuild, @vanbesien, @deguio, @davidlange6 can you please check and sign again.

@bbilin
Copy link
Contributor Author

bbilin commented Mar 9, 2016

solved. Thanks a lot.

@davidlange6
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11819/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@deguio
Copy link
Contributor

deguio commented Mar 24, 2016

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit ebae92d into cms-sw:CMSSW_8_1_X Mar 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants