Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement BRIL DQM client #13690

Merged
merged 1 commit into from
Apr 14, 2016
Merged

Implement BRIL DQM client #13690

merged 1 commit into from
Apr 14, 2016

Conversation

dmitrijus
Copy link
Contributor

No description provided.

@cmsbuild cmsbuild added this to the Next CMSSW_8_0_X milestone Mar 11, 2016
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @dmitrijus (Dmitrijus) for CMSSW_8_0_X.

It involves the following packages:

DQM/Bril
DQM/Integration
DQMServices/StreamerIO

The following packages do not have a category, yet:

DQM/Bril

@cmsbuild, @vanbesien, @deguio, @davidlange6 can you please review it and eventually sign? Thanks.
@barvic, @threus, @batinkov this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@deguio
Copy link
Contributor

deguio commented Mar 15, 2016

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11883/console

@dmitrijus
Copy link
Contributor Author

Don't +1 this yet, there will be more commits to it.

@deguio
Copy link
Contributor

deguio commented Mar 15, 2016

and we need the 81x version

@cmsbuild
Copy link
Contributor

+1
Tested at: 65467a9
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13690/11883/summary.html

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13690/11883/summary.html

@cmsbuild
Copy link
Contributor

Pull request #13690 was updated. @cmsbuild, @vanbesien, @deguio, @davidlange6 can you please check and sign again.

@smuzaffar
Copy link
Contributor

hold
please do not add a new package just to hold one source file. Please move BrilClient.* to some existing DQM package.

@cmsbuild
Copy link
Contributor

Pull request has been put on hold by @smuzaffar
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

@cmsbuild cmsbuild added the hold label Mar 16, 2016
@dmitrijus
Copy link
Contributor Author

BRIL is somewhat independent DQM entity.
@deguio should provide more comments and make a decision.

@davidlange6
Copy link
Contributor

perhaps we can make a combined package with the pixellumi stuff (which is brill)

@cmsbuild
Copy link
Contributor

Pull request #13690 was updated. @cmsbuild, @vanbesien, @deguio, @davidlange6 can you please check and sign again.

@dmitrijus
Copy link
Contributor Author

Moved it to DQM/PixelLumi.

@cmsbuild
Copy link
Contributor

Pull request #13690 was updated. @cmsbuild, @vanbesien, @deguio, @davidlange6 can you please check and sign again.

@deguio
Copy link
Contributor

deguio commented Mar 17, 2016

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11947/console

@cmsbuild
Copy link
Contributor

+1
Tested at: b4d6456
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13690/11947/summary.html

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13690/11947/summary.html

@deguio
Copy link
Contributor

deguio commented Mar 22, 2016

please provide 81 version of this one.

1 similar comment
@deguio
Copy link
Contributor

deguio commented Mar 24, 2016

please provide 81 version of this one.

@dmitrijus dmitrijus mentioned this pull request Mar 24, 2016
Merged
@dmitrijus
Copy link
Contributor Author

Done and +1 :)

@deguio
Copy link
Contributor

deguio commented Mar 24, 2016

+1
thanks

@deguio
Copy link
Contributor

deguio commented Apr 5, 2016

+1
please un-hold this PR

@davidlange6 davidlange6 merged commit 7dee7c8 into cms-sw:CMSSW_8_0_X Apr 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-available dqm-approved hold orp-pending pending-signatures tests-approved
Projects
None yet
Milestone
CMSSW_8_0_X
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dmitrijus @cmsbuild @deguio @smuzaffar @davidlange6