New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rekovic hlt 802 seed unpacked gt (pruning on top of PR 13703) #13707
Rekovic hlt 802 seed unpacked gt (pruning on top of PR 13703) #13707
Conversation
A new Pull Request was created by @rekovic for CMSSW_8_1_X. It involves the following packages: HLTrigger/HLTfilters @Martin-Grunewald, @perrotta, @cmsbuild, @davidlange6, @fwyzard can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
Woha, you are removing much more than in the most recent commit for 80X: ?? |
@Martin-Grunewald, I am not sure what you are referring to. |
In my browser, the latter shows only one file changed, while the former shows two files changed! |
cms-l1t-offline@8931109 was pushed first to rekovic-hlt-802-seed-unpackedGT branch. It re-triggered the 8_0_X #13702. In case of this 8_1_X, previous #13703 was already completed. So this new 8_1_X PR contains both commits at once. At the end of the day, #13702 and this should contain same commits. |
ok |
please test |
The tests are being triggered in jenkins. |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
+1 |
…npackedGT Rekovic hlt 802 seed unpacked gt (pruning on top of PR 13703)
Removal of currently inactive parts of the seeding module, on top of #13703 which was merged in CMSSW_8_1_X earlier today.
Integration into CMSSW_8_0_X is still ongoing in #13702, so no need for a new PR there.
This will keep integration in CMSSW_8_1_X and CMSSW_8_0_X in sync.