Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rekovic hlt 802 seed unpacked gt (pruning on top of PR 13703) #13707

Merged

Conversation

rekovic
Copy link
Contributor

@rekovic rekovic commented Mar 14, 2016

Removal of currently inactive parts of the seeding module, on top of #13703 which was merged in CMSSW_8_1_X earlier today.
Integration into CMSSW_8_0_X is still ongoing in #13702, so no need for a new PR there.
This will keep integration in CMSSW_8_1_X and CMSSW_8_0_X in sync.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @rekovic for CMSSW_8_1_X.

It involves the following packages:

HLTrigger/HLTfilters

@Martin-Grunewald, @perrotta, @cmsbuild, @davidlange6, @fwyzard can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@Martin-Grunewald
Copy link
Contributor

Woha,

you are removing much more than in the most recent commit for 80X:
cms-l1t-offline@e7d038f

??

@rekovic
Copy link
Contributor Author

rekovic commented Mar 14, 2016

@Martin-Grunewald, I am not sure what you are referring to.
There are two same commits in PR for 80X and 81X
cms-l1t-offline@8931109
cms-l1t-offline@e7d038f
Can you elaborate?

@Martin-Grunewald
Copy link
Contributor

In my browser, the latter shows only one file changed, while the former shows two files changed!

@rekovic
Copy link
Contributor Author

rekovic commented Mar 14, 2016

cms-l1t-offline@8931109 was pushed first to rekovic-hlt-802-seed-unpackedGT branch. It re-triggered the 8_0_X #13702.
cms-l1t-offline@e7d038f was pushed immediately after, and it re-triggered the PR again.

In case of this 8_1_X, previous #13703 was already completed. So this new 8_1_X PR contains both commits at once.

At the end of the day, #13702 and this should contain same commits.

@Martin-Grunewald
Copy link
Contributor

ok

@Martin-Grunewald
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11866/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@Martin-Grunewald
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Mar 15, 2016
…npackedGT

Rekovic hlt 802 seed unpacked gt (pruning on top of PR 13703)
@cmsbuild cmsbuild merged commit 331eaa0 into cms-sw:CMSSW_8_1_X Mar 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants