Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-IOV weak mode constraints (Backport of #13710) #13712

Merged

Conversation

ghellwig
Copy link

Feature allows to constrain the tracker alignment procedure to avoid the introduction of weak modes.
Includes extension of the existing code to support multi-IOV alignments + clean-up of existing code.

Presented at Tracker Alignment meeting 16 March 2016:
https://indico.cern.ch/event/504824/session/0/contribution/65/attachments/1244395/1831868/talk.pdf

Backport of #13710

  Introduced some C++11 features to streamline the code.
 - Create constraint configurations for each IOV.
 - technically working: compiling and pede does not complain
   -> Need to verify that the result looks as expected
 - empty IOVs are problematic because the associated parameters are removed by
   pede's cut on the number of hits (since there are 0 hits)
   -> either ignore IOVs by providing a list of IOVs
      or use pede option 'skipemptycons' (preferred)
 - default (next level) behaviour can be changed now
 - added configuration flag to apply constraint at lowest level
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ghellwig (Gregor Mittag) for CMSSW_7_6_X.

It involves the following packages:

Alignment/CommonAlignment
Alignment/MillePedeAlignmentAlgorithm

@diguida, @cerminar, @cmsbuild, @franzoni, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks.
@mschrode, @pakhotin, @mmusich, @tocheng, @tlampen this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@mmusich
Copy link
Contributor

mmusich commented Mar 15, 2016

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11892/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@mmusich
Copy link
Contributor

mmusich commented Mar 17, 2016

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit ad6b65c into cms-sw:CMSSW_7_6_X Apr 12, 2016
@ghellwig ghellwig deleted the multi-iov_weak-mode-constraints_76X branch April 18, 2016 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants