Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bsunanda:Run2-alca37 Fix bug to avoid run-time error for Pythia8 #13720

Merged
merged 1 commit into from Mar 15, 2016

Conversation

bsunanda
Copy link
Contributor

No description provided.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @bsunanda for CMSSW_8_1_X.

It involves the following packages:

GeneratorInterface/GenFilters

@vciulli, @covarell, @thuer, @cmsbuild, @bendavid, @davidlange6, @govoni can you please review it and eventually sign? Thanks.
@agrohsje, @mkirsano this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@bsunanda
Copy link
Contributor Author

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11878/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@covarell
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1
wondering how this did not get noticed in the validation done before requesting a back port (and a special release, which is wasted..)

cmsbuild added a commit that referenced this pull request Mar 15, 2016
bsunanda:Run2-alca37 Fix bug to avoid run-time error for Pythia8
@cmsbuild cmsbuild merged commit 0f43789 into cms-sw:CMSSW_8_1_X Mar 15, 2016
@covarell
Copy link
Contributor

@bsunanda should answer this, but I believe a particle not recognized by PDT must be a very rare event (usually these errors are triggered by some weird light mesons)

@bsunanda
Copy link
Contributor Author

I concentrated on Pythia6 at that time which had no such errors. For Pythia8 it is very rare but it happens when one goes above a few 1000 events. We understand that Pythia8 will now be used and in that process we discovered the shortcoming. Sorry for overlooking this.


From: Roberto Covarelli [notifications@github.com]
Sent: 15 March 2016 15:46
To: cms-sw/cmssw
Cc: Sunanda Banerjee
Subject: Re: [cmssw] bsunanda:Run2-alca37 Fix bug to avoid run-time error for Pythia8 (#13720)

@bsunandahttps://github.com/bsunanda should answer this, but I believe a particle not recognized by PDT must be a very rare event (usually these errors are triggered by some weird light mesons)


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
#13720 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants