Avoid unneeded retrievel of per event provenance #13722
Conversation
|
A new Pull Request was created by @wmtan for CMSSW_8_1_X. It involves the following packages: Calibration/HcalAlCaRecoProducers @smuzaffar, @diguida, @cvuosalo, @cerminar, @monttj, @cmsbuild, @alja, @franzoni, @Dr15Jones, @deguio, @slava77, @vadler, @mmusich, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
wmtan
force-pushed
the
DoNotReadPerEventProvenanceIfNotNeeded
branch
from
ff25955
to
f9475af
Compare
|
@cmsbuild please test |
|
The tests are being triggered in jenkins. |
|
please test |
|
+1 |
|
The tests are being triggered in jenkins. |
|
Comparison not run due to Build errors (RelVals and Igprof tests were also skipped) |
|
-1 >> Compiling /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-03-14-1100/src/Fireworks/Core/src/CmsShowEDI.cc
In file included from /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-03-14-1100/src/Fireworks/Core/src/FWEveView.cc:41:0:
/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-03-14-1100/src/Fireworks/Core/interface/FWEventAnnotation.h:4:27: warning: /cvmfs/cms-ib.cern.ch/2016-12/slc6_amd64_gcc530/lcg/root/6.06.00-giojec/include/TGLAnnotation.h is shorter than expected
>> Compiling /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-03-14-1100/src/Fireworks/Core/src/FWGeometry.cc
/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-03-14-1100/src/Fireworks/Core/src/FWViewContextMenuHandlerGL.cc: In member function 'virtual void FWViewContextMenuHandlerGL::select(int, const FWModelId&, int, int)':
/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-03-14-1100/src/Fireworks/Core/src/FWViewContextMenuHandlerGL.cc:67:116: error: invalid use of incomplete type 'class TGLAnnotation'
TGLAnnotation _an = new TGLAnnotation(v, name.c_str(), x_1.f/f->GetWidth(), 1 - y*1.f/f->GetHeight(), pnt);
^
In file included from /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-03-14-1100/src/Fireworks/Core/src/FWViewContextMenuHandlerGL.cc:12:0:
/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-03-14-1100/src/Fireworks/Core/interface/FWEveView.h:30:7: note: forward declaration of 'class TGLAnnotation'
class TGLAnnotation;
you can see the results of the tests here: |
|
@smuzaffar I can't imagine that the changes are not gcc53 compatible, but I will build against gcc53 just to be sure. |
cmsbuild
added
dqm-pending
tests-pending
and removed
dqm-approved
tests-rejected
labels
|
Pull request #13722 was updated. @smuzaffar, @diguida, @cvuosalo, @cerminar, @monttj, @cmsbuild, @alja, @franzoni, @Dr15Jones, @deguio, @slava77, @vadler, @mmusich, @vanbesien, @davidlange6 can you please check and sign again. |
|
Comparison is ready The workflows 140.53 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons |
|
please test |
|
The tests are being triggered in jenkins. |
|
@smuzaffar I built this PR with gcc530, and there were no build errors. |
|
-1 Tested at: ab05d71 ---> test runtestTqafTopEventSelection had ERRORS you can see the results of the tests here: |
|
+1 |
cmsbuild
added
core-approved
visualization-approved
and removed
core-pending
visualization-pending
labels
|
The test failures are unrelated to this pull request. |
|
-1 Tested at: ab05d71 ---> test testRecoMETMETProducers had ERRORS you can see the results of the tests here: |
|
Comparison is ready The workflows 140.53 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons |
|
Comparison is ready The workflows 140.53 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons |
…Needed Avoid unneeded retrievel of per event provenance
This pull request replaces most calls of getAllProvenance() with calls of a new function, getAllStableProvenance(), which avoids accessing the portions of the provenance that may change each event. This avoids a potential problem with thread safety. None of the replaced calls used the per event provenance, anyway. This PR solves issue #13624 .