Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

L1T Stage2 development since l1t-tsg-v3 #13723

Closed
wants to merge 248 commits into from
Closed

L1T Stage2 development since l1t-tsg-v3 #13723

wants to merge 248 commits into from

Conversation

rekovic
Copy link
Contributor

@rekovic rekovic commented Mar 15, 2016

This includes the latest developments in various L1T emulators which have been developed
since CMSSW_8_0_0_pre6 and have been integrated and ported to CMSSW_8_0_2.

This is the latest tag (l1t-integration-v14.0) of l1t-integration-CMSSW_8_0_2,
and it has major bug fixes of Layer-1 on top of l1t-integration-v13.1 which was equivalent to l1t-tsg-v4.

Emulation comparison rates have been tested on both data and MC and they are equivalent
to those of l1t-integration-v13.1 (i.e. l1t-tsg-v4) as the Layer-1 has been turned off.

mulhearn and others added 30 commits February 9, 2016 12:14
@mulhearn
update L1T standard sequences
5406f87
@mulhearn
cleanup summary module and related customs
d8e4835
@mulhearn
add ReEmul customization for cmsDriver workflows and more utilities
b0824f2
@tstreble @mulhearn
Update EG isolation + Tau calibration LUTs
7dcb5dc
@bundocka @mulhearn
Fixed HBHENoiseFilterResult
3d742d9
@mulhearn
new emulator for calo layer1
8fc7039
@mulhearn
unpacker for calo layer1
c168773
@SridharaDasu @mulhearn
Added HF 1x1 handling
dae3208
@SridharaDasu @mulhearn
Added HF tower handling
e12adb7
@SridharaDasu @mulhearn
Fixed so HF TPs are appended to regular collection with version set to 1
0be1a05
@SridharaDasu @mulhearn
Removed empty hfTPGDigis stub :(
9734d82
@SridharaDasu @mulhearn
Added access to uctPhi() from tower for correct CaloTower making
4b1cedf
@SridharaDasu @mulhearn
Added run number and dataset selection ability at run time to test sc…
91b0a53 
…ript - thanks Nick Smith
@mulhearn
move test code out of deprecated L1TCaloLayer1RawToDigi
6bfc69b
@mulhearn
remove deprecated EventFilter/L1TCaloLayer1RawToDigi
2bd812a
@mulhearn
fix l1t text summary in example code
2865eac
@mulhearn
make L1TCaloLayer1 a drop in replacement, leave off by default
3489e9e
@davignon @mulhearn
Added Options 4 and 5 isolation LUTs for taus
5897e1b 
Conflicts:
	L1Trigger/L1TCalorimeter/data/Flat_Tau_iso_LUT_eff70.txt
	L1Trigger/L1TCalorimeter/data/Flat_Tau_iso_LUT_eff80.txt
	L1Trigger/L1TCalorimeter/data/Flat_Tau_iso_LUT_eff90.txt
@mulhearn
quiet verbose reEmul example
fe177ee
@mrcarver @mulhearn
Added absolute value operator to z-coordinate variable
faf8e0a
@mulhearn
disable GMT regional muon packing until fixed
df59949
@mulhearn
bugfix for standard sequences for pre6
0aa725f
@mulhearn
remove unsupported examples
d5352f6
@mulhearn
bugfix summary output and remove obsolete customs
3f8977c
@mulhearn
add muons to emulation ntuple
2e2000a
@mulhearn
re-emulate HCAL TPs by default in reEmul custom
e95c1eb
@mulhearn
remove inadvertent override of HCAL TP re-emulation
4f28e8c
@thomreis @mulhearn
Check the size of the track address map before using it when builting…
74785f1 
… the raw track address.
@thomreis @mulhearn
Bugfix: Every BX, not just the first one, is now filled with 6 empty …
66fd6f6 
…muons if no muon was in the BX.
@akalinow @mulhearn
* make get methods of L1TMuonOverlapParams to be const
0531a74 
* the phi angle converions follows hardware mroe closely
@Martin-Grunewald
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11937/console

@smuzaffar
Copy link
Contributor

Is L1 category responsible for these new packages?

@Martin-Grunewald
Copy link
Contributor

@smuzaffar
yes indeed!

@rekovic
Copy link
Contributor Author

rekovic commented Mar 17, 2016

@smuzaffar @Martin-Grunewald
Mike (@mulhearn) said yesterday that he needs to add xxxx/data files to the l1t integration branch.

@Martin-Grunewald
Copy link
Contributor

@rekovic @mulhearn
Into the release or into some external in case those files are largeish (recall the L1Tmenu xml files were moved to an external)

@rekovic
Copy link
Contributor Author

rekovic commented Mar 17, 2016

@Martin-Grunewald
I will let @mulhearn comment.

He will probably close this PR and make a new one.

@cmsbuild
Copy link
Contributor

+1
Tested at: a39bc20
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13723/11937/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
6f148fd
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13723/11937/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13723/11937/git-merge-result

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13723/11937/summary.html

@Martin-Grunewald
Copy link
Contributor

I suppose this one is now superseded by #13767, correct?
And thus can be closed...?

@rekovic
Copy link
Contributor Author

rekovic commented Mar 18, 2016

We can close this PR.

PR #13767 is only the migration of data files from the l1t-tsg-v4 branch.
After merged into CMSSW, there will be another PR to merge the rest
of the branch, I learn.

@rekovic
Copy link
Contributor Author

rekovic commented Mar 18, 2016

@mulhearn you are interested in this.

@cmsbuild
Copy link
Contributor

Pull request #13723 was updated. @diguida, @cerminar, @cmsbuild, @franzoni, @ggovi, @mmusich, @mulhearn, @davidlange6 can you please check and sign again.

@rekovic rekovic closed this Mar 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
alca-pending comparison-pending db-pending l1-pending new-package-pending orp-pending pending-signatures tests-pending
Projects
None yet
Milestone
CMSSW_8_0_X
Development

Successfully merging this pull request may close these issues.

None yet