Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RectangularEtaPhiTrackingRegion (80X) #13730

Merged
merged 1 commit into from Mar 17, 2016

Conversation

makortel
Copy link
Contributor

Backport of #13729. Original description:

This PR fixes a bug introduced in #11624, where in an if statement a pixel barrel was required, but it should have been pixel endcap.

Branch is based on 7_6_0, and it was tested in 8_0_1. In the PR tests there are probably no changes visible because the affected code path does not get run.

@rovere @VinInn

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @makortel (Matti Kortelainen) for CMSSW_8_0_X.

It involves the following packages:

RecoTracker/TkTrackingRegions

@cmsbuild, @cvuosalo, @davidlange6, @slava77 can you please review it and eventually sign? Thanks.
@ghellwig, @GiacomoSguazzoni, @rovere, @VinInn, @mschrode, @istaslis, @gpetruc, @cerati, @dgulhan this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@slava77
Copy link
Contributor

slava77 commented Mar 15, 2016

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11909/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@cvuosalo
Copy link
Contributor

+1

For #13730 eee116c

Fixing a tracking region bug that is probably actually never encountered in standard workflows. There should be no change in monitored quantities.

#13729 and #13731 are the 81X and 76X versions of this PR, and the former has already been approved.

Jenkins tests against baseline CMSSW_8_0_X_2016-03-15-1100 show no significant differences, as expected.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Mar 17, 2016
Fix RectangularEtaPhiTrackingRegion (80X)
@cmsbuild cmsbuild merged commit d26718c into cms-sw:CMSSW_8_0_X Mar 17, 2016
@makortel makortel deleted the fixRectangularTrackingRegions branch October 20, 2016 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants