Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Thread safe fixes for DataFormats/PatCandidates #1375

Closed
wants to merge 15 commits into from
Closed

Thread safe fixes for DataFormats/PatCandidates #1375

wants to merge 15 commits into from

Conversation

Dr15Jones
Copy link
Contributor

Changed caches used by the data products to be thread-safe. Also dealt with non-const statics.

Volker Adler and others added 9 commits November 3, 2013 22:36
Migration to 'getByToken', part III.
fcb5d2b
Add missing second token for same InputTag.
05e7864
Import missing Winter13 BTag performance DB from CVS
3547bf8
@Dr15Jones
Removed the need for a non-const static in UserData.
09594c2 
Moved the calculation of the name demangling to a static function of the base class. This allowed the removal of a non-const static and avoided having to create that code for each template type. The const static name only needs call that function once per job. This will avoid a potential thread-safety issue.
@Dr15Jones
Changed a non-const function static to a const class static in Accept…
be8e04f 
…AllFilter

The class AcceptAllFilter has a method singleton method 'get' which was creating a non-const function static and returning it a const. This was replaced with a const class static so that the compiler didn't have to create code in each calling file for the function static. This avoids having the static analyzer produce a thread-safety complaint.
@Dr15Jones
Made caching thread-safe in pat::MET
50a422a 
Used std::atomic<*> to manage a thread safe cache of information. This dropped a transient data member so classes_def_objects.xml file had to be changed.
@Dr15Jones
Added reset method to AtomicPtrCache
98f9fe2 
After using AtomicPtrCache in real code, we found that a dedicated reset() method makes the code cleaner. Previously one had to create a temporary empty AtomicPtrCache and assign it to the old variable in order to reset.
@Dr15Jones
Merge branch 'addResetToAtomicPtrCache' into threadSafeFixesDataForma…
8c73628 
…tsPatCandidates
@Dr15Jones
Made pat::Tau and pat::Jet thread-safe
3b05568 
Changed caches to be of type edm::AtomicPtrCache<> to avoid thread safety issues.
@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 7, 2013

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_0_X.

Thread safe fixes for DataFormats/PatCandidates

It involves the following packages:

DataFormats/PatCandidates
DataFormats/Common

@cmsbuild, @vadler, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks.
@wmtan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.

@Dr15Jones
Copy link
Contributor Author

+1
The change to edm::AtomicPtrCache is from a merge with PR #1371

@ktf
Merge pull request cms-sw#1311 from vadler/70X-consumesMigration-III
6b936cc 
Consumes migration -- PFBRECO
@ktf
Merge pull request cms-sw#1363 from blinkseb/70x_winter13_btag_db
497ff46 
Reco update -- Import missing Winter13 BTag performance DB from CVS
@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 8, 2013

-1
I ran the usual tests and I found errors in the following unit tests:

---> test runtestPhysicsToolsPatAlgos had ERRORS
---> test runtestTqafTopEventSelection had ERRORS
---> test runtestTqafExamples had ERRORS
---> test runtestTqafTopJetCombination had ERRORS
---> test runtestTqafTopKinFitter had ERRORS
---> test runtestTqafTopHitFit had ERRORS
---> test runtestTqafTopTools had ERRORS
---> test runtestTqafTopEventProducers had ERRORS

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/1252/summary.html

ktf and others added 4 commits November 8, 2013 02:47
@ktf
Merge pull request cms-sw#1371 from Dr15Jones/addResetToAtomicPtrCache
83c428f 
Multithreaded framework -- Added reset method to AtomicPtrCache
@Dr15Jones
Fixed typo in operator* which was never called before
b285a65 
The non-const version of operator* was missing a ‘*’ and was not caught since it had not been called.
Updated the unit test so it tests all the functions, both const and non-const.
@Dr15Jones
Merged refs/pull/1387/head from repository cms-sw
e5b6176
@Dr15Jones
Work around problem with ROOT when using a transient edm::AtomicPtrCache
1fac273 
ROOT 5 complains about ROOT iorules for edm::AtomicPtrCache even though it is a transient data member. I spoke with Philippe Canal and he said it is a deficiency of Cintex and will not be in ROOT 6. This is a work around until we move to ROOT 6.
@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 8, 2013

Pull request #1375 was updated. @nclopezo, @cmsbuild, @Dr15Jones, @slava77, @vadler, @ktf, @thspeer can you please check and sign again.

@Dr15Jones
Copy link
Contributor Author

I had merged in PR #1387 and it now makes it look like I have 99 files changed. I'll try a rebase instead.

@Dr15Jones Dr15Jones closed this Nov 8, 2013
@Dr15Jones Dr15Jones deleted the threadSafeFixesDataFormatsPatCandidates branch November 8, 2013 15:15
@Dr15Jones Dr15Jones mentioned this pull request Nov 8, 2013
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
analysis-pending core-pending pending-signatures reconstruction-pending tests-pending
Projects
None yet
Milestone
CMSSW_7_0_0_pre9
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Dr15Jones @cmsbuild @ktf