Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix in the BoostedDoubleSV tagger (80X) #13751

Conversation

ferencek
Copy link
Contributor

Bugfix for the BoostedDoubleSV tagger. The bug is expected to manifest itself in extremely rare instances where a jet has only one constituent. The fix has no impact on RECO (since the tagger is not run there) but could impact MiniAOD in those rare instances.

This is a 80X backport of #13749

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ferencek (Dinko Ferenček) for CMSSW_8_0_X.

It involves the following packages:

RecoBTag/SecondaryVertex

@cmsbuild, @cvuosalo, @davidlange6, @slava77 can you please review it and eventually sign? Thanks.
@ferencek, @acaudron, @pvmulder, @imarches this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@slava77
Copy link
Contributor

slava77 commented Mar 17, 2016

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11943/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@cvuosalo
Copy link
Contributor

+1

For #13751 892a1ae

Small bug fix for the BoostedDoubleSV tagger. There should be no change in monitored quantities.

#13749 is the 81X version of this PR.

The code changes are satisfactory, and Jenkins tests against baseline CMSSW_8_0_X_2016-03-16-2300 show no significant differences, as expected.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Mar 21, 2016
…-CMSSW_8_0_2

Bugfix in the BoostedDoubleSV tagger (80X)
@cmsbuild cmsbuild merged commit 1115bbb into cms-sw:CMSSW_8_0_X Mar 21, 2016
@ferencek ferencek deleted the BoostedDoubleSVBugfix_from-CMSSW_8_0_2 branch March 21, 2016 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants