Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FastSim HF timing from SL #13754

Merged
merged 1 commit into from Apr 25, 2016
Merged

FastSim HF timing from SL #13754

merged 1 commit into from Apr 25, 2016

Conversation

Vlandr57
Copy link
Contributor

Tmestamp for HF FastSim hits is taken from Shower Library

@cmsbuild cmsbuild added this to the Next CMSSW_8_1_X milestone Mar 17, 2016
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Vlandr57 for CMSSW_8_1_X.

It involves the following packages:

FastSimulation/Calorimetry
FastSimulation/ShowerDevelopment

@ssekmen, @lveldere, @civanch, @mdhildreth, @cmsbuild, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @matt-komm this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@lveldere
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11958/console

@cmsbuild
Copy link
Contributor

+1
Tested at: 93238b0
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13754/11958/summary.html

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13754/11958/summary.html

@lveldere
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 9bca7dd into cms-sw:CMSSW_8_1_X Apr 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-available fastsim-approved fully-signed orp-approved tests-approved
Projects
None yet
Milestone
Next CMSSW_8_1_X
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Vlandr57 @cmsbuild @lveldere @davidlange6