Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

barrel vs ladder in roc level in 81x #13759

Merged
merged 5 commits into from May 11, 2016

Conversation

gouskos
Copy link
Contributor

@gouskos gouskos commented Mar 17, 2016

add DQM plot for the Pixel barrel

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @gouskos for CMSSW_8_1_X.

It involves the following packages:

DQM/SiPixelMonitorTrack

@cmsbuild, @vanbesien, @deguio, @davidlange6 can you please review it and eventually sign? Thanks.
@threus this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@deguio
Copy link
Contributor

deguio commented Mar 24, 2016

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12048/console

@cmsbuild
Copy link
Contributor

-1
Tested at: 3b4d55f
When I ran the RelVals I found an error in the following worklfows:
4.22 step2

runTheMatrix-results/4.22_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC/step2_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC.log
----- Begin Fatal Exception 24-Mar-2016 15:48:17 CET-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=SiPixelTrackResidualSource label='SiPixelTrackResidualSource_Cosmics'
Exception Message:
MissingParameter: Parameter 'digisrc' not found.
----- End Fatal Exception -------------------------------------------------

8.0 step3

runTheMatrix-results/8.0_BeamHalo+BeamHalo+DIGICOS+RECOCOS+ALCABH+HARVESTCOS/step3_BeamHalo+BeamHalo+DIGICOS+RECOCOS+ALCABH+HARVESTCOS.log
----- Begin Fatal Exception 24-Mar-2016 15:51:28 CET-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=SiPixelTrackResidualSource label='SiPixelTrackResidualSource_Cosmics'
Exception Message:
MissingParameter: Parameter 'digisrc' not found.
----- End Fatal Exception -------------------------------------------------

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13759/12048/summary.html

@deguio
Copy link
Contributor

deguio commented Apr 5, 2016

-1
please fix cosmics configs. the digisrc parameter is needed there.

@cmsbuild
Copy link
Contributor

Pull request #13759 was updated. @cmsbuild, @vanbesien, @deguio, @davidlange6 can you please check and sign again.

@deguio
Copy link
Contributor

deguio commented Apr 19, 2016

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12483/console

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13759/12483/summary.html

The workflows 134.911 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

remove cout.
@cmsbuild
Copy link
Contributor

Pull request #13759 was updated. @cmsbuild, @dmitrijus, @vanbesien, @deguio, @davidlange6 can you please check and sign again.

@deguio
Copy link
Contributor

deguio commented May 4, 2016

please test

@deguio
Copy link
Contributor

deguio commented May 4, 2016

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented May 4, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12815/console

@cmsbuild
Copy link
Contributor

cmsbuild commented May 4, 2016

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented May 4, 2016

@cmsbuild
Copy link
Contributor

cmsbuild commented May 4, 2016

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 094df58 into cms-sw:CMSSW_8_1_X May 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants