Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

relval matrix updates #13797

Conversation

hengne
Copy link
Contributor

@hengne hengne commented Mar 22, 2016

relval updates:

  • add phase1 ZMM_13 pythia8 workflow
  • update gensim input for phase1
  • finer job splitting for phase1 digi and reco steps
  • update mixing/premixing inputs for 2015 workflows
  • JpsiMuMu_Pt-15 workflow update to JpsiMuMu_Pt-8 with Pythia8

@cmsbuild cmsbuild added this to the Next CMSSW_8_1_X milestone Mar 22, 2016
@hengne
Copy link
Contributor Author

hengne commented Mar 22, 2016

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12005/console

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @hengne (Hengne Li) for CMSSW_8_1_X.

It involves the following packages:

Configuration/PyReleaseValidation

@boudoul, @franzoni, @fabozzi, @cmsbuild, @srimanob, @hengne, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @Martin-Grunewald this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

wmsplit['DigiFull']=5
wmsplit['RecoFull']=5
wmsplit['DigiFullPU']=1
wmsplit['RecoFullPU']=1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these really effect only the very high pileup workflows?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

first two lines are for noPU workflows 5 lumis/job, last two lines are for PU workflows 1 lumi/job. I just take the same configs as for 2015 workflows.

@cmsbuild
Copy link
Contributor

-1

Tested at: 819c129
I found errors in the following unit tests:

---> test runtestTqafTopEventSelection had ERRORS

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13797/12005/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
87b7530
8580f6e
bb9ac08
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13797/12005/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13797/12005/git-merge-result

@hengne
Copy link
Contributor Author

hengne commented Mar 23, 2016

There are the following errors:
1.) in unitTest, there is mainly the database connection error :

####### Case1: Connect to an invalid database.
CORAL/Services/XMLLookupService Error Could not open "dblookup.xml" for reading
# Expected Error: No physical Update connection for "invalid" is available. ( CORAL : "ReplicaCatalogue::replicasForConnection" from "CORAL/Services/ConnectionService" )
####### Case2: Connect to a valid database. Transaction not started.

2.) Matrix Test, there are two DAS errors.

All seem to be temporary connection errors to me. I will test it again.

@hengne
Copy link
Contributor Author

hengne commented Mar 23, 2016

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12019/console

@cmsbuild
Copy link
Contributor

-1
Tested at: 819c129
When I ran the RelVals I found an error in the following worklfows:
25202.0 step3

runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25/step3_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25.log
----- Begin Fatal Exception 23-Mar-2016 14:53:19 CET-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=MixingModule label='mix'
Exception Message:
RootEmbeddedFileSequence no input files specified for secondary input source.
----- End Fatal Exception -------------------------------------------------

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13797/12021/summary.html

@hengne
Copy link
Contributor Author

hengne commented Mar 23, 2016

for the same das_client.py HTTPError i will wait until this issue has been solved to test again.

@boudoul
Copy link
Contributor

boudoul commented Mar 23, 2016

Just for my own education, since this is the step3 which is failing because of query to the pile up dataset, , why do we have the pile up option in the step3 (reco step) ? I naively though the pile up option was needed only for the digi step ? (non urgent it's really for my own curiosity)

@hengne
Copy link
Contributor Author

hengne commented Mar 23, 2016

me too... i don't really understand... the mixing should be done at the DIGI step. but would the RAW2DIGI in the reco step also makes such a das_client query?

@davidlange6
Copy link
Contributor

the validation step effectively redoes all the mixing.. (apparently implemented as a second das query to get the files)

On Mar 23, 2016, at 5:14 PM, Hengne Li notifications@github.com wrote:

me too... i don't really understand... the mixing should be done at the DIGI step. but would the RAW2DIGI in the reco step also makes such a das_client query?


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub

@boudoul
Copy link
Contributor

boudoul commented Mar 23, 2016

ah it's the validation step , ok thanks!

@hengne
Copy link
Contributor Author

hengne commented Mar 24, 2016

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12038/console

@cmsbuild
Copy link
Contributor

@hengne
Copy link
Contributor Author

hengne commented Mar 24, 2016

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 4671860 into cms-sw:CMSSW_8_1_X Mar 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants