Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix consumes for alignment validations #13814

Merged
merged 7 commits into from Mar 28, 2016

Conversation

hroskes
Copy link
Contributor

@hroskes hroskes commented Mar 23, 2016

and a few other assorted fixes

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @hroskes (Heshy Roskes) for CMSSW_8_1_X.

It involves the following packages:

Alignment/OfflineValidation
RecoTracker/TrackProducer

@cvuosalo, @cerminar, @cmsbuild, @franzoni, @slava77, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @makortel, @GiacomoSguazzoni, @rovere, @VinInn, @mschrode, @tocheng, @tlampen, @gpetruc, @istaslis, @mmusich, @cerati, @dgulhan this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@mmusich
Copy link
Contributor

mmusich commented Mar 23, 2016

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12024/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@cvuosalo
Copy link
Contributor

+1

For #13814 8177566

Fixing consumes for alignment validations. There should be no change in monitored quantities.

#13815 and #13816 are the 80X and 76X versions of this PR.

The code changes are satisfactory, and Jenkins tests against baseline CMSSW_8_1_X_2016-03-23-1100 show no significant differences, as expected.

@mmusich
Copy link
Contributor

mmusich commented Mar 24, 2016

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 5e65373 into cms-sw:CMSSW_8_1_X Mar 28, 2016
@hroskes hroskes deleted the fix-consumes-alignment-80X branch April 8, 2016 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants