Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bsunanda:Phase2-gem11 More realistic ME0 geometry and extended GE21 geometry #13834

Merged
merged 1 commit into from Apr 2, 2016

Conversation

bsunanda
Copy link
Contributor

GE21 geometry is currently used to study 4-layer vs 2-layer option

@bsunanda
Copy link
Contributor Author

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12060/console

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @bsunanda for CMSSW_8_1_X.

It involves the following packages:

Geometry/MuonCommonData

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@bsunanda
Copy link
Contributor Author

@ianna @civanch Could you sign this PR?

@bsunanda
Copy link
Contributor Author

@ianna @civanch We would like this to be integrated soon because the ME0 part should go in as the default

@civanch
Copy link
Contributor

civanch commented Mar 30, 2016

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

@bsunanda - are all 8 versions really still under consideration?

@bsunanda
Copy link
Contributor Author

I believe not. I shall clarify from GEM DPG and get rid of the versions which are no longer necessary.


From: David Lange [notifications@github.com]
Sent: 30 March 2016 18:24
To: cms-sw/cmssw
Cc: Sunanda Banerjee
Subject: Re: [cms-sw/cmssw] bsunanda:Phase2-gem11 More realistic ME0 geometry and extended GE21 geometry (#13834)

@bsunandahttps://github.com/bsunanda - are all 8 versions really still under consideration?


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHubhttps://github.com//pull/13834#issuecomment-203512297

@calabria
Copy link
Contributor

@davidlange6 no absolutely not, they are different version we created in time with continuos improvements... if you are worried about the proliferation of possible geometries for the 2023 scenario, we want to use just one option, the other ones are there for special studies, other ones are quite old. If instead you want simply to make some cleaning we can check and remove old geometries/files/folders.

@davidlange6
Copy link
Contributor

I don’t need one - but 8 is getting more than excessive:) if new versions mean old versions are obsolete, please remove, or better yet, overwrite the old versions. Git in any case tracks the full history

On Mar 30, 2016, at 6:43 PM, Cesare notifications@github.com wrote:

@davidlange6 no absolutely not, they are different version we created in time with continuos improvements... if you are worried about the proliferation of possible geometries for the 2023 scenario, we want to use just one option, the other ones are there for special studies, other ones are quite old. If instead you want simply to make some cleaning we can check and remove old geometries/files/folders.


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub

@bsunanda
Copy link
Contributor Author

@davidlange66 We are working on this. We shall reduce the number of versions in near future. But could you integrate this PR and we would make a proposal for retaining only the ones we use at the moment


From: David Lange [notifications@github.com]
Sent: 30 March 2016 18:50
To: cms-sw/cmssw
Cc: Sunanda Banerjee
Subject: Re: [cms-sw/cmssw] bsunanda:Phase2-gem11 More realistic ME0 geometry and extended GE21 geometry (#13834)

I don’t need one - but 8 is getting more than excessive:) if new versions mean old versions are obsolete, please remove, or better yet, overwrite the old versions. Git in any case tracks the full history

On Mar 30, 2016, at 6:43 PM, Cesare notifications@github.com wrote:

@davidlange6 no absolutely not, they are different version we created in time with continuos improvements... if you are worried about the proliferation of possible geometries for the 2023 scenario, we want to use just one option, the other ones are there for special studies, other ones are quite old. If instead you want simply to make some cleaning we can check and remove old geometries/files/folders.


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHubhttps://github.com//pull/13834#issuecomment-203522629

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 6123950 into cms-sw:CMSSW_8_1_X Apr 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants