New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bsunanda:Phase2-gem11 More realistic ME0 geometry and extended GE21 geometry #13834
Conversation
@cmsbuild Please test |
The tests are being triggered in jenkins. |
A new Pull Request was created by @bsunanda for CMSSW_8_1_X. It involves the following packages: Geometry/MuonCommonData @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
@bsunanda - are all 8 versions really still under consideration? |
I believe not. I shall clarify from GEM DPG and get rid of the versions which are no longer necessary. From: David Lange [notifications@github.com] @bsunandahttps://github.com/bsunanda - are all 8 versions really still under consideration? — |
@davidlange6 no absolutely not, they are different version we created in time with continuos improvements... if you are worried about the proliferation of possible geometries for the 2023 scenario, we want to use just one option, the other ones are there for special studies, other ones are quite old. If instead you want simply to make some cleaning we can check and remove old geometries/files/folders. |
I don’t need one - but 8 is getting more than excessive:) if new versions mean old versions are obsolete, please remove, or better yet, overwrite the old versions. Git in any case tracks the full history
|
@davidlange66 We are working on this. We shall reduce the number of versions in near future. But could you integrate this PR and we would make a proposal for retaining only the ones we use at the moment From: David Lange [notifications@github.com] I don’t need one - but 8 is getting more than excessive:) if new versions mean old versions are obsolete, please remove, or better yet, overwrite the old versions. Git in any case tracks the full history
— |
+1 |
GE21 geometry is currently used to study 4-layer vs 2-layer option