CTPPS: new DataFormats related to TOTEM RP raw data and digi

[jan-kaspar]

1st pull request out of 3 related to TOTEM RP raw-data unpacking and raw-to-digi conversion.

Validation config included in the 3rd pull request (EventFilter).

[cmsbuild]

A new Pull Request was created by @jan-kaspar for CMSSW_8_1_X.

It involves the following packages:

DataFormats/TotemRPDetId
DataFormats/TotemRPDigi
DataFormats/TotemRPL1
DataFormats/TotemRawData

The following packages do not have a category, yet:

DataFormats/TotemRPDetId
DataFormats/TotemRPDigi
DataFormats/TotemRPL1
DataFormats/TotemRawData

@cmsbuild, @davidlange6 can you please review it and eventually sign? Thanks.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

[slava77]

• TotemRPL1 should be renamed to L1TotemRP. See the patterns in https://github.com/cms-sw/cmssw/tree/CMSSW_8_0_X/DataFormats
• classes internal to Raw2DigiProducer should probably stay in the same package adn the producer itself DataFormats/TotemRawData. If we have digis, I don't see a good reason to keep them in DataFormats/ with objects intended to be saved in standard output data streams/datasets.
• classes_def.xml should have class versions (start from 2) together with checksums for all basic classes (not templated or derived from templates)
• CMS style is to start with lower case for all class methods (excluding constructors and destructors). E.g. e.g. in TotRPDetId.h int Station() should be int station()

[slava77]

@cmsbuild please test
to see if more issues come up in compilation

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12068/console

[cmsbuild]

+1
Tested at: 1140a72
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13837/12068/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13837/12068/summary.html

[jan-kaspar]

@slava77

TotemRPL1 should be renamed to L1TotemRP. See the patterns in https://github.com/cms-sw/cmssw/tree/CMSSW_8_0_X/DataFormats

OK

classes internal to Raw2DigiProducer should probably stay in the same package adn the producer itself DataFormats/TotemRawData. If we have digis, I don't see a good reason to keep them in DataFormats/ with objects intended to be saved in standard output data streams/datasets.

I am not sure whether I understand. DataFormats/TotemRawData contains non-digi data that we save in Event:

• TotemRawEvent: various counters from DAQ and Trigger
• TotemRawToDigiStatus: status of raw-to-digi conversion for each read-out chip (VFAT), this was important for some analyses

classes_def.xml should have class versions (start from 2) together with checksums for all basic classes (not templated or derived from templates)

OK

CMS style is to start with lower case for all class methods (excluding constructors and destructors). E.g. e.g. in TotRPDetId.h int Station() should be int station()

How strict is this requirement? Unfortunately, most of our code has method names starting with a capital...

[slava77]

On 3/26/16 1:07 PM, jan-kaspar wrote:

CMS style is to start with lower case for all class methods
(excluding constructors and destructors). E.g. e.g. in TotRPDetId.h
int Station() should be int station()

How strict is this requirement? Unfortunately, most of our code has
method names starting with a capital...

Consistency in the data formats method naming is more important that in
the algorithms.
Isn't it just a search-and-replace, which can probably be sed scripted

[slava77]

I think this is not necessary anymore

[slava77]

you can go back to struct.
class with public data member is worse.

[cmsbuild]

Pull request #13837 was updated. @civanch, @cvuosalo, @mdhildreth, @cmsbuild, @slava77, @davidlange6 can you please check and sign again.

[jan-kaspar]

@slava77 Struct is back.

[civanch]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12350/console

[slava77]

+1

for #13837 b836b2a

• the last update adds a default initialization for TotemTriggerCounters.h struct. Compilation is enough (jenkins is done compiling by now)

[cmsbuild]

+1
Tested at: b836b2a
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13837/12350/summary.html

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13837/12350/summary.html

[davidlange6]

+1