CTPPS: new CondFormats related to TOTEM RP raw data and digi #13838

jan-kaspar · 2016-03-25T15:29:37Z

2nd pull request out of 3 related to TOTEM RP raw-data unpacking and raw-to-digi conversion.

Validation config included in the 3rd pull request (EventFilter).

raw-to-digi.

cmsbuild · 2016-03-25T15:29:59Z

A new Pull Request was created by @jan-kaspar for CMSSW_8_1_X.

It involves the following packages:

CondFormats/DataRecord
CondFormats/TotemReadoutObjects
DataFormats/TotemRPDetId
DataFormats/TotemRPDigi
DataFormats/TotemRPL1
DataFormats/TotemRawData

The following packages do not have a category, yet:

CondFormats/TotemReadoutObjects
DataFormats/TotemRPDetId
DataFormats/TotemRPDigi
DataFormats/TotemRPL1
DataFormats/TotemRawData

@cerminar, @cmsbuild, @franzoni, @ggovi, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks.
@apfeiffer1, @tocheng this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

mmusich · 2016-03-25T16:25:26Z

please test

cmsbuild · 2016-03-25T16:25:51Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12065/console

cmsbuild · 2016-03-25T18:09:47Z

+1
Tested at: 0426ab0
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13838/12065/summary.html

slava77 · 2016-03-26T16:56:48Z

@mmusich
once we confirm CondFormats/TotemReadoutObjects to be an OK name for the package,
please edit categories.py file in cms-sw/cms-bot (can edit online and submit a PR based on that edit).

slava77 · 2016-03-26T17:18:43Z

CondFormats/TotemReadoutObjects/interface/TotemDAQMapping.h

+#ifndef _TotemDAQMapping_h_
+#define _TotemDAQMapping_h_
+
+#include "DataFormats/TotemRawData/interface/TotemFramePosition.h"


TotemFramePosition looks like the only "DataFromats/" object included here.
Looking at it, the class describes the hardware channel ID, something that is fixed for that geometry or logical hardware element and doesn't change between events.
In other detectors we have such objects in CondFormats/[DetectorName]Objects

slava77 · 2016-03-26T18:31:28Z

@jan-kaspar
In the tests summary #13838 (comment)
you can see in the "Static checks outputs" that there are some issues with the code
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13838/12065/llvm-analysis/
these better be addressed as well

jan-kaspar · 2016-03-26T20:24:55Z

@slava77 Looking at the "Static checks outputs" I have some questions.

Is only catch (...) forbidden or any kind of catch?
Is the problem with inheriting from edm:EDAnalzer that now you prefer to inherit from edm::one::EDAnalyzer<> ?

Thanks!

slava77 · 2016-03-26T23:32:56Z

On 3/26/16 1:24 PM, jan-kaspar wrote:

@slava77 https://github.com/slava77 Looking at the "Static checks
outputs" I have some questions.
Is only |catch (...)| forbidden or any kind of |catch|?

Exception throw and catch can not be used to communicate between pieces
of code that we control.
XercesDOMParser is an external.
If we know types of exceptions it can throw it may be better to replace
the "...".

Here you rethrow with a more useful message.
I think that it should be OK to catch

Is the problem with inheriting from |edm:EDAnalzer| that now you
prefer to inherit from |edm::one::EDAnalyzer<>| ?

edm::one looks good for this.

Thanks!

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#13838 (comment)

slava77 · 2016-03-29T14:03:38Z

something to get cms-bot to update the signatures

cmsbuild · 2016-03-29T14:04:03Z

Pull request #13838 was updated. @civanch, @cvuosalo, @mdhildreth, @franzoni, @cerminar, @slava77, @ggovi, @mmusich, @davidlange6 can you please check and sign again.

slava77 · 2016-03-31T16:09:48Z

cms-bot : update the labels

slava77 · 2016-04-01T15:03:26Z

@mmusich @franzoni @ggovi
please clarify on the status of review of files in CondFormats.
There were no comments from alca or db for 7 days already.
Thank you.

mmusich · 2016-04-01T15:20:11Z

@slava77 thanks for the heads up, we are in the process of reviewing. from a quick view looks like CondFormats are not mapped to Records @ggovi to comment more.

cmsbuild · 2016-04-14T16:46:59Z

Pull request #13838 was updated. @cerminar, @cmsbuild, @franzoni, @ggovi, @mmusich, @davidlange6 can you please check and sign again.

jan-kaspar · 2016-04-14T17:10:29Z

Sorry, the commit adc852b was done in error.

The merge conflicts should be now resolved.

slava77 · 2016-04-14T17:42:33Z

@cmsbuild please test

cmsbuild · 2016-04-14T17:44:43Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12386/console

cmsbuild · 2016-04-14T18:05:39Z

+1
Tested at: adc852b
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13838/12384/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
adc852b
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13838/12384/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13838/12384/git-merge-result

cmsbuild · 2016-04-14T19:10:28Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13838/12384/summary.html

cmsbuild · 2016-04-14T20:49:46Z

+1
Tested at: b06a72a
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13838/12386/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
b06a72a
adc852b
9066410
85ffdfe
abd4163
6bf9fcb
a329cf2
1c34f76
9630b9e
49aa681
623e81c
7dee7c8
a3da602
5bdbb54
f30cae3
60f96ea
39e3419
085d92a
3d88376
3063aac
fce6718
dc1314b
02909a0
ef96fe2
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13838/12386/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13838/12386/git-merge-result

cmsbuild · 2016-04-14T21:51:01Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13838/12386/summary.html

ggovi · 2016-04-15T09:23:52Z

+1

davidlange6 · 2016-04-19T08:38:17Z

@franzoni @mmusich - any comments on this PR ? we should merge it today if no further questions

mmusich · 2016-04-19T08:39:31Z

@davidlange6 I think after talking with CT-PPS representatives last Friday we decided to ease integration by merging this first.

mmusich · 2016-04-19T08:39:34Z

+1

CTPPS: new CondFormats related to TOTEM RP raw data and digi - backport of #13838

Import from CTPPS repository: conditions formats needed for TOTEM RP

0426ab0

raw-to-digi.

cmsbuild added this to the Next CMSSW_8_1_X milestone Mar 25, 2016

cmsbuild added alca-pending db-pending pending-signatures tests-pending orp-pending new-package-pending comparison-pending labels Mar 25, 2016

cmsbuild added tests-started and removed tests-pending labels Mar 25, 2016

cmsbuild added tests-approved and removed tests-started labels Mar 25, 2016

slava77 mentioned this pull request Mar 26, 2016

CTPPS: new EventFilter for raw-to-digi conversion of TOTEM RP data #13839

Merged

slava77 reviewed Mar 26, 2016
View reviewed changes

cmsbuild added reconstruction-pending simulation-pending labels Mar 29, 2016

cmsbuild added tests-started and removed tests-pending labels Apr 14, 2016

cmsbuild added comparison-available and removed comparison-pending labels Apr 14, 2016

cmsbuild added tests-approved comparison-pending and removed comparison-available tests-started labels Apr 14, 2016

cmsbuild added comparison-available and removed comparison-pending labels Apr 14, 2016

cmsbuild added db-approved and removed db-pending labels Apr 15, 2016

cmsbuild added alca-approved and removed alca-pending labels Apr 19, 2016

davidlange6 merged commit 221e750 into cms-sw:CMSSW_8_1_X Apr 19, 2016

jan-kaspar deleted the ctpps_raw_cond_formats branch April 19, 2016 08:50

grzanka mentioned this pull request May 23, 2016

CTPPS: new CondFormats related to TOTEM RP raw data and digi - backport of #13838 #14600

Merged

davidlange6 added a commit that referenced this pull request May 27, 2016

Merge pull request #14600 from CTPPS/ctpps_raw_cond_formats_backport

a7a5e87

CTPPS: new CondFormats related to TOTEM RP raw data and digi - backport of #13838

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CTPPS: new CondFormats related to TOTEM RP raw data and digi #13838

CTPPS: new CondFormats related to TOTEM RP raw data and digi #13838

jan-kaspar commented Mar 25, 2016

cmsbuild commented Mar 25, 2016

mmusich commented Mar 25, 2016

cmsbuild commented Mar 25, 2016

cmsbuild commented Mar 25, 2016

slava77 commented Mar 26, 2016

slava77 Mar 26, 2016

slava77 commented Mar 26, 2016

jan-kaspar commented Mar 26, 2016

slava77 commented Mar 26, 2016

slava77 commented Mar 29, 2016

cmsbuild commented Mar 29, 2016

slava77 commented Mar 31, 2016

slava77 commented Apr 1, 2016

mmusich commented Apr 1, 2016

cmsbuild commented Apr 14, 2016

jan-kaspar commented Apr 14, 2016

slava77 commented Apr 14, 2016

cmsbuild commented Apr 14, 2016

cmsbuild commented Apr 14, 2016

cmsbuild commented Apr 14, 2016

cmsbuild commented Apr 14, 2016

cmsbuild commented Apr 14, 2016

ggovi commented Apr 15, 2016

davidlange6 commented Apr 19, 2016

mmusich commented Apr 19, 2016

mmusich commented Apr 19, 2016

CTPPS: new CondFormats related to TOTEM RP raw data and digi #13838

CTPPS: new CondFormats related to TOTEM RP raw data and digi #13838

Conversation

jan-kaspar commented Mar 25, 2016

cmsbuild commented Mar 25, 2016

mmusich commented Mar 25, 2016

cmsbuild commented Mar 25, 2016

cmsbuild commented Mar 25, 2016

slava77 commented Mar 26, 2016

slava77 Mar 26, 2016

Choose a reason for hiding this comment

slava77 commented Mar 26, 2016

jan-kaspar commented Mar 26, 2016

slava77 commented Mar 26, 2016

slava77 commented Mar 29, 2016

cmsbuild commented Mar 29, 2016

slava77 commented Mar 31, 2016

slava77 commented Apr 1, 2016

mmusich commented Apr 1, 2016

cmsbuild commented Apr 14, 2016

jan-kaspar commented Apr 14, 2016

slava77 commented Apr 14, 2016

cmsbuild commented Apr 14, 2016

cmsbuild commented Apr 14, 2016

cmsbuild commented Apr 14, 2016

cmsbuild commented Apr 14, 2016

cmsbuild commented Apr 14, 2016

ggovi commented Apr 15, 2016

davidlange6 commented Apr 19, 2016

mmusich commented Apr 19, 2016

mmusich commented Apr 19, 2016