SiStrip Bad channel estimation from FED error

CalibTracker/Records/interface/SiStripDependentRecords.h

@@ -9,6 +9,7 @@
 #include "Geometry/Records/interface/TrackerDigiGeometryRecord.h"
 #include "DataFormats/TrackerCommon/interface/TrackerTopology.h"
 #include "CondFormats/DataRecord/interface/RunSummaryRcd.h"
+#include "CondFormats/DataRecord/interface/SiStripFedCablingRcd.h"
 
 class SiStripFecCablingRcd : public edm::eventsetup::DependentRecordImplementation<SiStripFecCablingRcd,
   boost::mpl::vector<SiStripFedCablingRcd> > {};
@@ -23,7 +24,6 @@ class SiStripRegionCablingRcd : public edm::eventsetup::DependentRecordImplement
 class SiStripGainRcd : public edm::eventsetup::DependentRecordImplementation<SiStripGainRcd, boost::mpl::vector<SiStripApvGainRcd, SiStripApvGain2Rcd, SiStripApvGain3Rcd> > {};
 class SiStripGainSimRcd : public edm::eventsetup::DependentRecordImplementation<SiStripGainSimRcd, boost::mpl::vector<SiStripApvGainSimRcd> > {};
 
-class SiStripQualityRcd : public edm::eventsetup::DependentRecordImplementation<SiStripQualityRcd, boost::mpl::vector<SiStripBadModuleRcd, SiStripBadFiberRcd, SiStripBadChannelRcd, SiStripBadStripRcd, SiStripDetCablingRcd, SiStripDCSStatusRcd, SiStripDetVOffRcd, RunInfoRcd> > {};
 
 class SiStripDelayRcd : public edm::eventsetup::DependentRecordImplementation<SiStripDelayRcd, boost::mpl::vector<SiStripBaseDelayRcd> > {};
 
@@ -37,5 +37,9 @@ class SiStripNoisesDepRcd : public edm::eventsetup::DependentRecordImplementatio
 
 class SiStripBadModuleDepRcd : public edm::eventsetup::DependentRecordImplementation<SiStripBadModuleDepRcd, boost::mpl::vector<SiStripBadModuleRcd,IdealGeometryRecord> > {};
 
+class SiStripBadModuleFedErrRcd : public edm::eventsetup::DependentRecordImplementation<SiStripBadModuleFedErrRcd, boost::mpl::vector<SiStripFedCablingRcd> > {};
+
+class SiStripQualityRcd : public edm::eventsetup::DependentRecordImplementation<SiStripQualityRcd, boost::mpl::vector<SiStripBadModuleRcd, SiStripBadFiberRcd, SiStripBadChannelRcd, SiStripBadStripRcd, SiStripDetCablingRcd, SiStripDCSStatusRcd, SiStripDetVOffRcd, RunInfoRcd, SiStripBadModuleFedErrRcd > > {};
+
 #endif 
 

CalibTracker/Records/src/SiStripDependentRecords.cc

@@ -16,3 +16,4 @@ EVENTSETUP_RECORD_REG(SiStripBackPlaneCorrectionDepRcd);
 EVENTSETUP_RECORD_REG(SiStripHashedDetIdRcd);
 EVENTSETUP_RECORD_REG(SiStripNoisesDepRcd);
 EVENTSETUP_RECORD_REG(SiStripBadModuleDepRcd);
+EVENTSETUP_RECORD_REG(SiStripBadModuleFedErrRcd);

CalibTracker/SiStripESProducers/BuildFile.xml

@@ -10,7 +10,9 @@
 <use   name="CondFormats/RunInfo"/>
 <use   name="Geometry/TrackerGeometryBuilder"/>
 <use   name="Geometry/Records"/>
+<use   name="DQMServices/Core"/>
 <use   name="boost"/>
+<use   name="classlib"/>
 <export>
   <lib   name="1"/>
 </export>

CalibTracker/SiStripESProducers/README.md

@@ -0,0 +1,27 @@
+### SiStrip fake ESSource to create SiStrip Bad channels from FED errors
+
+A new SiStrip fake source has been added to create Bad Components from the list of Fed detected errors. This
+is done using a histogram from DQM output where FedId vs APVId is plotted for detected channels.
+
+The tool inclides following components
+
+ - `SiStripBadModuleFedErrService`: the service defined in `CalibTracker/SiStripESProducers` package which 
+   accesses the specific histogram from the DQM root file (to be specified in the configuration) and creates
+   `SiStripBadStrip` object checking detected `FedChannel` and `FedId` and using `SiStripFedCabling` information.
+
+    - corresponding configuration is `CalibTracker/SiStripESProducers/python/services/SiStripBadModuleFedErrService_cfi.py`
+
+ - `SiStripBadModuleFedErrRcd` : the record defined in `CalibTracker/Records` package in `SiStripDependentRecords.h`
+    and `SiStripDependentRecords.cc`. This is a dependent record and depends on `SiStripFedCablingRcd'. This record
+    is filled with `SiStripBadStrip` object.
+
+ - `SiStripBadModuleFedErrFakeESSource` : the actual fake source is defined in the package `CalibTracker/SiStripESProducers` 
+   in `plugins/fake` area from the  template 'SiStripTemplateFakeESSource' in `modules.cc`. The record `SiStripBadModuleFedErrRcd`
+   is filled with the object `SiStripBadStrip`
+
+    - corresponding configuration file is `CalibTracker/SiStripESProducers/python/fake/SiStripBadModuleFedErrFakeESSource_cfi.py`
+
+
+ - An overall configuration file can be found in `CalibTracker/SiStripESProducers/test/mergeBadChannel_cfg.py` which merges
+   SiStrip Bad channels from PLC, `RunInfo` and SiStripBadModuleFedErrFakeESSource in `SiStripQualityEsProducer` and finally
+   listed by the `SiStripQualityStatistics` module.

CalibTracker/SiStripESProducers/interface/SiStripBadModuleFedErrService.h

@@ -0,0 +1,49 @@
+#ifndef SiStripESSources_SiStripBadModuleFedErrService_h
+#define SiStripESSources_SiStripBadModuleFedErrService_h
+// -*- C++ -*-
+//
+//
+#include <string>
+
+#include "FWCore/Framework/interface/Frameworkfwd.h"
+#include "FWCore/ServiceRegistry/interface/Service.h"
+#include "FWCore/ParameterSet/interface/ParameterSet.h"
+#include "FWCore/Framework/interface/ESHandle.h"
+#include "CondTools/SiStrip/interface/SiStripDepCondObjBuilderBase.h"
+#include "CondFormats/SiStripObjects/interface/SiStripBadStrip.h"
+#include "CondFormats/SiStripObjects/interface/SiStripFedCabling.h"
+#include "DQMServices/Core/interface/DQMStore.h"
+
+class MonitorElement;
+class SiStripQuality;
+
+class SiStripBadModuleFedErrService : public SiStripDepCondObjBuilderBase<SiStripBadStrip, SiStripFedCabling> {
+
+public:
+
+  explicit SiStripBadModuleFedErrService(const edm::ParameterSet&,const edm::ActivityRegistry&);
+  ~SiStripBadModuleFedErrService();
+
+  /// Used to fill the logDB
+  void getMetaDataString(std::stringstream& ss);
+
+  /// Check is the transfer is needed
+  virtual bool checkForCompatibility(std::string ss);
+
+  void getObj(SiStripBadStrip* & obj, const SiStripFedCabling * cabling){obj = readBadComponentsFromFed(cabling);}
+  uint32_t getRunNumber() const;
+
+private:
+
+
+  SiStripBadStrip* readBadComponentsFromFed(const SiStripFedCabling* cabling);
+  bool openRequestedFile();
+  void getFedBadChannelList(MonitorElement* me, std::vector<std::pair<uint16_t, uint16_t>>& list);
+  float getProcessedEvents();
+
+  DQMStore* dqmStore_;
+
+  edm::ParameterSet iConfig_;
+  bool notAlreadyRead_;
+};
+#endif

CalibTracker/SiStripESProducers/plugins/fake/modules.cc

@@ -62,6 +62,11 @@ DEFINE_FWK_EVENTSETUP_SOURCE(SiStripNoisesFakeESSource);
 typedef SiStripTemplateDepFakeESSource< SiStripBadStrip, SiStripBadModuleDepRcd, SiStripBadModuleGenerator,IdealGeometryRecord,TrackerTopology > SiStripBadModuleConfigurableFakeESSource;
 DEFINE_FWK_EVENTSETUP_SOURCE(SiStripBadModuleConfigurableFakeESSource);
 
+#include "CondFormats/SiStripObjects/interface/SiStripBadStrip.h"
+#include "CalibTracker/SiStripESProducers/interface/SiStripBadModuleFedErrService.h"
+typedef SiStripTemplateDepFakeESSource< SiStripBadStrip, SiStripBadModuleFedErrRcd, SiStripBadModuleFedErrService, SiStripFedCablingRcd, SiStripFedCabling > SiStripBadModuleFedErrFakeESSource;
+DEFINE_FWK_EVENTSETUP_SOURCE(SiStripBadModuleFedErrFakeESSource);
+
 #include "CondFormats/SiStripObjects/interface/SiStripLorentzAngle.h"
 #include "CalibTracker/SiStripESProducers/interface/SiStripLorentzAngleGenerator.h"
 typedef SiStripTemplateDepFakeESSource< SiStripLorentzAngle, SiStripLorentzAngleDepRcd, SiStripLorentzAngleGenerator,IdealGeometryRecord,TrackerTopology > SiStripLorentzAngleFakeESSource;

CalibTracker/SiStripESProducers/plugins/real/SiStripQualityESProducer.cc

@@ -67,6 +67,9 @@ boost::shared_ptr<SiStripQuality> SiStripQualityESProducer::produce(const SiStri
     if (recordName=="SiStripBadModuleRcd"){
       iRecord.getRecord<SiStripBadModuleRcd>().get(tagName,obj); 
       quality->add( obj.product() );
+    } else if (recordName=="SiStripBadModuleFedErrRcd"){
+      iRecord.getRecord<SiStripBadModuleFedErrRcd>().get(tagName,obj); 
+      quality->add( obj.product() );
     } else if (recordName=="SiStripBadFiberRcd"){
       iRecord.getRecord<SiStripBadFiberRcd>().get(tagName,obj); 
       quality->add( obj.product() );    

CalibTracker/SiStripESProducers/plugins/services/modules.cc

@@ -40,3 +40,7 @@ DEFINE_FWK_SERVICE(SiStripBaseDelayGenerator);
 #include "FWCore/ServiceRegistry/interface/ServiceMaker.h"
 #include "CalibTracker/SiStripESProducers/interface/SiStripConfObjectGenerator.h"
 DEFINE_FWK_SERVICE(SiStripConfObjectGenerator);
+
+#include "FWCore/ServiceRegistry/interface/ServiceMaker.h"
+#include "CalibTracker/SiStripESProducers/interface/SiStripBadModuleFedErrService.h"
+DEFINE_FWK_SERVICE(SiStripBadModuleFedErrService);

CalibTracker/SiStripESProducers/python/fake/SiStripBadModuleFedErrFakeESSource_cfi.py

@@ -0,0 +1,7 @@
+import FWCore.ParameterSet.Config as cms
+
+from CalibTracker.SiStripESProducers.services.SiStripBadModuleFedErrService_cfi import *
+
+siStripBadModuleFedErrFakeESSource = cms.ESSource("SiStripBadModuleFedErrFakeESSource",
+                                                   appendToDataLabel = cms.string('')
+                                                 )

CalibTracker/SiStripESProducers/python/services/SiStripBadModuleFedErrService_cfi.py

@@ -0,0 +1,12 @@
+import FWCore.ParameterSet.Config as cms
+
+siStripBadModuleFedErrService = cms.Service("SiStripBadModuleFedErrService",
+                                       appendToDataLabel = cms.string(''),
+                                       ReadFromFile = cms.bool(True),  
+                                       FileName = cms.string('DQM.root'),
+                                       BadStripCutoff = cms.double(0.8)
+                                       )
+
+
+
+

CalibTracker/SiStripESProducers/src/SiStripBadModuleFedErrService.cc

@@ -0,0 +1,168 @@
+
+#include "CalibTracker/SiStripESProducers/interface/SiStripBadModuleFedErrService.h"
+#include "FWCore/MessageLogger/interface/MessageLogger.h"
+#include "DQMServices/Core/interface/MonitorElement.h"
+#include "CalibFormats/SiStripObjects/interface/SiStripQuality.h"
+
+#include "boost/cstdint.hpp"
+#include "boost/lexical_cast.hpp"
+
+#include <cctype>
+#include <time.h>
+
+#include <iostream>
+#include <sstream>
+#include <string>
+#include <vector>
+
+using namespace std;
+
+SiStripBadModuleFedErrService::SiStripBadModuleFedErrService(const edm::ParameterSet& iConfig,const edm::ActivityRegistry& aReg):
+  SiStripDepCondObjBuilderBase<SiStripBadStrip,SiStripFedCabling>::SiStripDepCondObjBuilderBase(iConfig),
+  iConfig_(iConfig)
+{
+  edm::LogInfo("SiStripBadModuleFedErrService") <<  "[SiStripBadModuleFedErrService::SiStripBadModuleFedErrService]";
+}
+
+SiStripBadModuleFedErrService::~SiStripBadModuleFedErrService()
+{
+  edm::LogInfo("SiStripBadModuleFedErrService") <<  "[SiStripBadModuleFedErrService::~SiStripBadModuleFedErrService]";
+}
+
+void SiStripBadModuleFedErrService::getMetaDataString(std::stringstream& ss)
+{
+  ss << "Run " << getRunNumber() << std::endl;
+  obj_->printSummary(ss);
+}
+
+bool SiStripBadModuleFedErrService::checkForCompatibility(std::string ss)
+{
+  std::stringstream localString;
+  getMetaDataString(localString);
+  if( ss == localString.str() ) return false;
+
+  return true;
+}
+
+SiStripBadStrip* SiStripBadModuleFedErrService::readBadComponentsFromFed(const SiStripFedCabling *  cabling) {
+
+
+  SiStripQuality* obj_  = new SiStripQuality();
+
+  bool readFlag = iConfig_.getParameter<bool>("ReadFromFile");
+  dqmStore_ = edm::Service<DQMStore>().operator->();
+
+
+  if (readFlag && !openRequestedFile()) return obj_;
+
+  dqmStore_->cd();
+
+  std::string dname = "SiStrip/ReadoutView";
+  std::string hpath = dname;
+  hpath += "/FedIdVsApvId";
+  if (dqmStore_->dirExists(dname)) {    
+    MonitorElement* me = dqmStore_->get(hpath);
+    if (me) {
+      std::vector<std::pair<uint16_t, uint16_t>> channelList;
+      getFedBadChannelList(me, channelList); 
+      uint16_t fId_last = 9999;
+      uint16_t fChan_last = 9999;
+      std::map< uint32_t , std::set<int> > detectorMap;
+      for (std::vector<std::pair<uint16_t, uint16_t>>::iterator it = channelList.begin(); it != channelList.end(); it++) {
+	uint16_t fId = it->first;        
+
+	uint16_t fChan = it->second/2;
+        if (fId == fId_last && fChan == fChan_last) continue;
+
+	FedChannelConnection channel = cabling->fedConnection(fId, fChan);
+	const uint32_t detId =  channel.detId(); 
+	const uint16_t ipair = channel.apvPairNumber();
+        detectorMap[detId].insert(ipair);
+      }
+      for (std::map< uint32_t , std::set<int> >::iterator im =  detectorMap.begin(); im != detectorMap.end(); im++) {
+        const uint32_t detId = im->first;
+	std::set<int> pairs = im->second;		
+        SiStripQuality::InputVector theSiStripVector;	  
+	unsigned short firstBadStrip = 0;
+	unsigned short fNconsecutiveBadStrips = 0;
+	unsigned int theBadStripRange;
+        int last_pair = -1;
+	for (std::set<int>::iterator ip = pairs.begin(); ip != pairs.end(); ip++) {
+          if (last_pair == -1) {
+	    firstBadStrip = (*ip) * 128 * 2;
+	    fNconsecutiveBadStrips = 128*2;
+	  } else if ((*ip) - last_pair  > 1) {
+	    theBadStripRange = obj_->encode(firstBadStrip,fNconsecutiveBadStrips);       
+	    theSiStripVector.push_back(theBadStripRange);
+	    firstBadStrip = (*ip) * 128 * 2;
+	    fNconsecutiveBadStrips = 128*2;
+	  } else { 
+	    fNconsecutiveBadStrips += 128*2;
+	  }
+          last_pair = (*ip);
+	}
+	theBadStripRange = obj_->encode(firstBadStrip,fNconsecutiveBadStrips);       
+	theSiStripVector.push_back(theBadStripRange);
+
+	edm::LogInfo("SiStripBadModuleFedErrService") << " SiStripBadModuleFedErrService::readBadComponentsFromFed " 
+						      << " detid " << detId 
+						      << " firstBadStrip " << firstBadStrip 
+						      << " NconsecutiveBadStrips " << fNconsecutiveBadStrips 
+						      << " packed integer " << std::hex << theBadStripRange  << std::dec; 
+	SiStripBadStrip::Range range(theSiStripVector.begin(),theSiStripVector.end());
+	if ( !obj_->put(detId,range) ) {
+	  edm::LogError("SiStripBadModuleFedErrService")<<"[SiStripBadModuleFedErrService::readBadComponentsFromFed] detid already exists"<<std::endl; 
+	} 
+      }
+      obj_->cleanUp();
+    }
+  }
+  return obj_;
+}
+
+
+bool SiStripBadModuleFedErrService::openRequestedFile() {
+
+  std::string fileName = iConfig_.getParameter<std::string>("FileName");
+
+  edm::LogInfo("SiStripBadModuleFedErrService") <<  "[SiStripBadModuleFedErrService::openRequestedFile] Accessing root File" << fileName;
+
+  if (!dqmStore_->load(fileName, DQMStore::OpenRunDirs::StripRunDirs, true) ) {
+    edm::LogError("SiStripBadModuleFedErrService")<<"[SiStripBadModuleFedErrService::openRequestedFile] Requested file " << fileName << "Can not be opened!! ";
+    return false;
+  } else return true;
+}
+
+uint32_t SiStripBadModuleFedErrService::getRunNumber() const {
+  edm::LogInfo("SiStripBadModuleFedErrService") <<  "[SiStripBadModuleFedErrService::getRunNumber] " << iConfig_.getParameter<uint32_t>("RunNumber");
+  return iConfig_.getParameter<uint32_t>("RunNumber");
+}
+void SiStripBadModuleFedErrService::getFedBadChannelList(MonitorElement* me, std::vector<std::pair<uint16_t,uint16_t> >& list) {
+  float cutoff = iConfig_.getParameter<double>("BadStripCutoff");
+  if (me->kind() == MonitorElement::DQM_KIND_TH2F) {
+    TH2F* th2 = me->getTH2F();
+    float entries = getProcessedEvents();
+    if (!entries) entries = th2->GetBinContent(th2->GetMaximumBin()); 
+    for (uint16_t i = 1; i < th2->GetNbinsY()+1; i++) { 
+      for (uint16_t j = 1; j < th2->GetNbinsX()+1; j++) { 
+        if (th2->GetBinContent(j,i) > cutoff * entries) {
+	  edm::LogInfo("SiStripBadModuleFedErrService") << " [SiStripBadModuleFedErrService::getFedBadChannelList] :: FedId & Channel " << th2->GetYaxis()->GetBinLowEdge(i) <<   "  " << th2->GetXaxis()->GetBinLowEdge(j);
+          list.push_back(std::pair<uint16_t, uint16_t>(th2->GetYaxis()->GetBinLowEdge(i), th2->GetXaxis()->GetBinLowEdge(j)));  
+	}
+      }
+    }
+  }
+}
+float SiStripBadModuleFedErrService::getProcessedEvents() {
+
+  dqmStore_->cd();
+
+  std::string dname = "SiStrip/ReadoutView";
+  std::string hpath = dname;
+  hpath += "/nTotalBadActiveChannels";
+  if (dqmStore_->dirExists(dname)) {
+    MonitorElement* me = dqmStore_->get(hpath);
+    if (me) return (me->getEntries());
+  } 
+  return 0; 
+}

CalibTracker/SiStripESProducers/test/fedBadChannelFromNoiseRun_cfg.py

@@ -0,0 +1,51 @@
+import FWCore.ParameterSet.Config as cms
+
+process = cms.Process("fedBadChannelFromNoiseRun")
+process.MessageLogger = cms.Service("MessageLogger",
+    cout = cms.untracked.PSet(
+        threshold = cms.untracked.string('INFO')
+    ),
+    destinations = cms.untracked.vstring('cout')
+)
+process.load("Configuration.Geometry.GeometryRecoDB_cff")
+
+process.load('Configuration.StandardSequences.FrontierConditions_GlobalTag_cff')
+
+from Configuration.AlCa.GlobalTag import GlobalTag
+process.GlobalTag = GlobalTag(process.GlobalTag, 'auto:run2_data', '')
+
+
+process.source = cms.Source("EmptyIOVSource",
+    firstValue = cms.uint64(258714),
+    lastValue = cms.uint64(258714),
+    timetype = cms.string('runnumber'),
+    interval = cms.uint64(1)
+)
+
+process.maxEvents = cms.untracked.PSet(
+    input = cms.untracked.int32(-1)
+)
+process.load("CalibTracker.SiStripESProducers.fake.SiStripBadModuleFedErrFakeESSource_cfi")
+process.siStripBadModuleFedErrFakeESSource.appendToDataLabel = cms.string('BadModules_from_FEDBadChannel')
+process.SiStripBadModuleFedErrService.ReadFromFile = cms.bool(False)
+
+process.siStripQualityESProducer.ListOfRecordToMerge = cms.VPSet(
+        cms.PSet(record = cms.string('SiStripBadModuleFedErrRcd'), tag = cms.string('BadModules_from_FEDBadChannel'))
+#        cms.PSet(record = cms.string('SiStripDetCablingRcd'), tag = cms.string(''))
+)
+process.siStripQualityESProducer.ReduceGranularity = cms.bool(False)
+process.siStripQualityESProducer.ThresholdForReducedGranularity = cms.double(0.3)
+
+#### Add these lines to produce a tracker map
+process.load("DQMServices.Core.DQMStore_cfg")
+process.TkDetMap = cms.Service("TkDetMap")
+process.SiStripDetInfoFileReader = cms.Service("SiStripDetInfoFileReader")
+####
+
+process.stat = cms.EDAnalyzer("SiStripQualityStatistics",
+    dataLabel = cms.untracked.string('')
+)
+
+
+process.p = cms.Path(process.stat)
+