Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HLT L1T interface updates - trhow exceptions and L1GlobalDecision 80x #13903

Merged
merged 2 commits into from Apr 4, 2016

Conversation

rekovic
Copy link
Contributor

@rekovic rekovic commented Apr 3, 2016

Update to HLTL1TSeed.

  • Now throw exception (instead of error) in case of empty or unknown algo is in seeds logical expression.
  • Add functionality of passing seeding filter without seeds if L1GlobalDecision specified as seeds logical expression.

@rekovic
Copy link
Contributor Author

rekovic commented Apr 3, 2016

please test

@cmsbuild cmsbuild added this to the Next CMSSW_8_1_X milestone Apr 3, 2016
@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 3, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12146/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 3, 2016

A new Pull Request was created by @rekovic for CMSSW_8_1_X.

It involves the following packages:

HLTrigger/HLTfilters

@Martin-Grunewald, @perrotta, @cmsbuild, @fwyzard, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 3, 2016

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 3, 2016

@Martin-Grunewald
Copy link
Contributor

@rekovic
Nice, thanks!

@Martin-Grunewald
Copy link
Contributor

+1
(but only after both #13863 and #13892 are in)

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 4, 2016

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit a1b87ee into cms-sw:CMSSW_8_1_X Apr 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants