External conditions (technical) triggers for L1 Stage2. #13905
Conversation
…mulation sequence.
|
A new Pull Request was created by @rekovic for CMSSW_8_1_X. It involves the following packages: L1Trigger/Configuration @cmsbuild, @rekovic, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
|
+1 |
|
The tests are being triggered in jenkins. |
cmsbuild
added
l1-approved
fully-signed
and removed
l1-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
|
@rekovic |
|
@Martin-Grunewald There is no packer or unpacker for this external In HLT, the GT emulator uses the external conditions as part of the unpacked GT information process.hltGtStage2ObjectMap = cms.EDProducer("L1TGlobalProducer",
MuonInputTag = cms.InputTag("hltGmtStage2Digis","Muon"),
ExtInputTag = cms.InputTag("hltGtStage2Digis"), # (external conditions are not emulated, use unpacked)
Now, in simulation, we run the The GT emulator is configured to use it Now, if we want to re-emulate on Legacy 2015 data, the above producer in the simulation We can add this configuration specialisation. It is good to run on MC as is. |
|
@rekovic |
|
@Martin-Grunewald Yes, exactly. |
| const TechnicalTriggerWord& gtTTWord = gtReadoutRecord->technicalTriggerWord(useBx); | ||
| int tbitNumber = 0; | ||
| TechnicalTriggerWord::const_iterator GTtbitItr; | ||
| bool pass_BptxAND = false; |
There was a problem hiding this comment.
I would suggest putting these 4 bools into an array - then all the if statements below do not need the if elses
cmsbuild
added
l1-pending
pending-signatures
tests-pending
comparison-pending
and removed
comparison-available
fully-signed
l1-approved
tests-approved
labels
|
Pull request #13905 was updated. @cmsbuild, @rekovic, @mulhearn, @davidlange6 can you please check and sign again. |
|
@Martin-Grunewald Additions with customisation for cmsDriver will come in separately. |
|
+1 please test |
cmsbuild
added
l1-approved
fully-signed
and removed
l1-pending
pending-signatures
labels
|
The tests are being triggered in jenkins. |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
| bool pass_BptxMinus = false; | ||
| bool pass_BptxOR = false; | ||
|
|
||
| std::vector<bool> pass_externs(4, false); //BptxAND, BptxPlus, BptxMinus, BptxOR |
There was a problem hiding this comment.
even better if std::array - maybe next time?
|
+1 |
New producer for external conditions triggers for Stage2.
Included now in the L1T simulation sequence for Stage2.