New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Susy HLT DQM updates in 81x #13935
Susy HLT DQM updates in 81x #13935
Conversation
A new Pull Request was created by @olivito (Dominick Olivito) for CMSSW_8_1_X. It involves the following packages: HLTriggerOffline/SUSYBSM @cmsbuild, @vanbesien, @deguio, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
please test |
The tests are being triggered in jenkins. |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Just bumping this PR as it's been sitting for a week. There's also the 80x version, #13932. Thanks, |
Pull request #13935 was updated. @cmsbuild, @vanbesien, @deguio, @davidlange6 can you please check and sign again. |
I've added to this PR to update also some python configuration names for HT paths as they've changed in the latest HLT menu. Could you please check again and trigger the automatic tests? Thanks, |
please test |
The tests are being triggered in jenkins. |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
@@ -10,7 +10,7 @@ | |||
TriggerPath = cms.string('HLT_Ele10_CaloIdM_TrackIdM_CentralPFJet30_BTagCSV_p13_v'), | |||
TriggerFilterEle = cms.InputTag('hltSingleEle10CaloIdTrackIdVLDphiFilter', '', 'HLT'), #the last filter in the path hltSingleEle10CaloIdTrackIdVLOneOEMinusOneOPFilterRegional | |||
TriggerFilterJet = cms.InputTag('hltCSVFilterSingleEle10', '', 'HLT'), #the last filter in the path | |||
PtThrJet = cms.untracked.double(40.0), | |||
PtThrJet = cms.untracked.double(30.0), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perhaps it is worth putting this constant in one spot so that next time it changes you don't have to change it in 10 places? @olivito
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi David,
While that might be simpler, the issue is that not all SUSY DQM modules use the same cut because of different jet requirements in the HLT and in the analyses. Having a central constant would cause confusion in my opinion if it's not used everywhere. So I'd prefer to keep this as is.
Thanks,
Dominick
+1 |
Adding DQM monitoring for SUSY lepton fake rate paths, including new C++ code.
Updating python configurations for HT, HT+MET, MET paths to consolidate python code and add newly proposed trigger paths.
forward port of:
#13932