Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Susy HLT DQM updates in 81x #13935

Merged
merged 3 commits into from Apr 26, 2016
Merged

Conversation

olivito
Copy link
Contributor

@olivito olivito commented Apr 5, 2016

Adding DQM monitoring for SUSY lepton fake rate paths, including new C++ code.

Updating python configurations for HT, HT+MET, MET paths to consolidate python code and add newly proposed trigger paths.

forward port of:
#13932

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 5, 2016

A new Pull Request was created by @olivito (Dominick Olivito) for CMSSW_8_1_X.

It involves the following packages:

HLTriggerOffline/SUSYBSM

@cmsbuild, @vanbesien, @deguio, @davidlange6 can you please review it and eventually sign? Thanks.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@deguio
Copy link
Contributor

deguio commented Apr 5, 2016

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 5, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12186/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 5, 2016

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 5, 2016

@olivito
Copy link
Contributor Author

olivito commented Apr 12, 2016

Just bumping this PR as it's been sitting for a week. There's also the 80x version, #13932.

Thanks,
Dominick

@cmsbuild
Copy link
Contributor

Pull request #13935 was updated. @cmsbuild, @vanbesien, @deguio, @davidlange6 can you please check and sign again.

@olivito
Copy link
Contributor Author

olivito commented Apr 18, 2016

I've added to this PR to update also some python configuration names for HT paths as they've changed in the latest HLT menu. Could you please check again and trigger the automatic tests?

Thanks,
Dominick

@deguio
Copy link
Contributor

deguio commented Apr 19, 2016

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12484/console

@cmsbuild
Copy link
Contributor

@deguio
Copy link
Contributor

deguio commented Apr 21, 2016

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@@ -10,7 +10,7 @@
TriggerPath = cms.string('HLT_Ele10_CaloIdM_TrackIdM_CentralPFJet30_BTagCSV_p13_v'),
TriggerFilterEle = cms.InputTag('hltSingleEle10CaloIdTrackIdVLDphiFilter', '', 'HLT'), #the last filter in the path hltSingleEle10CaloIdTrackIdVLOneOEMinusOneOPFilterRegional
TriggerFilterJet = cms.InputTag('hltCSVFilterSingleEle10', '', 'HLT'), #the last filter in the path
PtThrJet = cms.untracked.double(40.0),
PtThrJet = cms.untracked.double(30.0),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perhaps it is worth putting this constant in one spot so that next time it changes you don't have to change it in 10 places? @olivito

Copy link
Contributor Author

@olivito olivito Apr 22, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi David,

@davidlange6

While that might be simpler, the issue is that not all SUSY DQM modules use the same cut because of different jet requirements in the HLT and in the analyses. Having a central constant would cause confusion in my opinion if it's not used everywhere. So I'd prefer to keep this as is.

Thanks,
Dominick

@davidlange6
Copy link
Contributor

+1
Ok, sound like extra work over time to me...

@cmsbuild cmsbuild merged commit a11f326 into cms-sw:CMSSW_8_1_X Apr 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants