Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small update of specifying event contents modules 81X #13948

Merged
merged 1 commit into from Apr 13, 2016

Conversation

jeongeun
Copy link
Contributor

@jeongeun jeongeun commented Apr 6, 2016

Fix PR#13612
Event Content Module Cleanup from unneeded wildcards

specific module

specific module

specific module

 specific module
@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 6, 2016

A new Pull Request was created by @jeongeun for CMSSW_8_1_X.

It involves the following packages:

Alignment/CommonAlignmentProducer
RecoHI/HiEgammaAlgos
RecoLocalCalo/Configuration

@cvuosalo, @cerminar, @cmsbuild, @franzoni, @slava77, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @pakhotin, @tlampen, @jazzitup, @richard-cms, @yenjie, @tocheng, @kurtejung, @mschrode, @istaslis, @mmusich, @mandrenguyen, @dgulhan, @yetkinyilmaz this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@mmusich
Copy link
Contributor

mmusich commented Apr 6, 2016

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 6, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12197/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 6, 2016

-1
Tested at: 852ef2e
When I ran the RelVals I found an error in the following worklfows:
1001.0 step1

DAS Error

1003.0 step1

DAS Error

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13948/12197/summary.html

@slava77
Copy link
Contributor

slava77 commented Apr 6, 2016

@cmsbuild please test
maybe no DAS errors this time

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 6, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12203/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 6, 2016

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 6, 2016

@mmusich
Copy link
Contributor

mmusich commented Apr 12, 2016

+1

@slava77
Copy link
Contributor

slava77 commented Apr 12, 2016

+1

for #13948 852ef2e

  • replacement of module instance wildcards with actually running module names looks correct
  • jenkins tests pass and comparisons with baseline show no difference
    • event product comparison of jenkins outputs in HI and pp workflows with RECO shows the same content

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit c834fb8 into cms-sw:CMSSW_8_1_X Apr 13, 2016
@jeongeun jeongeun deleted the smallfixModule81X branch May 26, 2020 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants