New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add selection based on PV error (needed by HI @HLT) #13981
add selection based on PV error (needed by HI @HLT) #13981
Conversation
A new Pull Request was created by @mtosi (mia tosi) for CMSSW_8_0_X. It involves the following packages: RecoTracker/FinalTrackSelectors @cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
@cmsbuild please test |
The tests are being triggered in jenkins. |
+1 Adding option for track selection to include the PV error, as needed by Heavy Ions. There should be no change in monitored quantities. The code changes are satisfactory, and Jenkins tests against baseline CMSSW_8_0_X_2016-04-06-2300 show no significant differences, as expected. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
Pull request #13981 was updated. @cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please check and sign again. |
@cmsbuild please test |
The tests are being triggered in jenkins. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
+1 |
backport in 80x PR #13980
this PR is meant to add the possibility of selecting tracks considering also the PV error
this feature was present in the AnalyticalTrackSelector, and it was missing in the new TrackCutClassifier
in last days, it turned out that it is used by HI