Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add selection based on PV error (needed by HI @HLT) #13981

Conversation

mtosi
Copy link
Contributor

@mtosi mtosi commented Apr 7, 2016

backport in 80x PR #13980

this PR is meant to add the possibility of selecting tracks considering also the PV error
this feature was present in the AnalyticalTrackSelector, and it was missing in the new TrackCutClassifier

in last days, it turned out that it is used by HI

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 7, 2016

A new Pull Request was created by @mtosi (mia tosi) for CMSSW_8_0_X.

It involves the following packages:

RecoTracker/FinalTrackSelectors

@cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @makortel, @GiacomoSguazzoni, @rovere, @VinInn, @mschrode, @istaslis, @gpetruc, @cerati, @dgulhan this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@slava77
Copy link
Contributor

slava77 commented Apr 7, 2016

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 7, 2016

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 7, 2016

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 7, 2016

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 7, 2016

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 7, 2016

@cvuosalo
Copy link
Contributor

+1

For #13981 098ab78

Adding option for track selection to include the PV error, as needed by Heavy Ions. There should be no change in monitored quantities.

The code changes are satisfactory, and Jenkins tests against baseline CMSSW_8_0_X_2016-04-06-2300 show no significant differences, as expected.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

Pull request #13981 was updated. @cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please check and sign again.

@cvuosalo
Copy link
Contributor

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12418/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@cvuosalo
Copy link
Contributor

+1

For #13981 3236896

Second approval after minor code revision to improve elegance. New Jenkins test results are still OK.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 5c1efdd into cms-sw:CMSSW_8_0_X Apr 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants