Be explicit about 'data' usage #14002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While compiling with GCC 6.0.0 (r234771) in C++1z mode compiler
produces extra diagnotic messages:
L1Trigger/GlobalCaloTrigger/test/testElectronSorter.cpp:47:3: error: reference to 'data' is ambiguous
L1Trigger/GlobalCaloTrigger/test/testElectronSorter.cpp:103:30: error: reference to 'data' is ambiguous
L1Trigger/GlobalCaloTrigger/test/testElectronSorter.cpp:104:27: error: reference to 'data' is ambiguous
L1Trigger/GlobalCaloTrigger/test/testElectronSorter.cpp:110:31: error: reference to 'data' is ambiguous
L1Trigger/GlobalCaloTrigger/test/testElectronSorter.cpp:111:5: error: reference to 'data' is ambiguous
L1Trigger/GlobalCaloTrigger/test/testElectronSorter.cpp:116:5: error: reference to 'data' is ambiguous
L1Trigger/GlobalCaloTrigger/test/testElectronSorter.cpp:121:5: error: reference to 'data' is ambiguous
L1Trigger/GlobalCaloTrigger/test/testElectronSorter.cpp:137:26: error: reference to 'data' is ambiguous
L1Trigger/GlobalCaloTrigger/test/testElectronSorter.cpp:138:7: error: reference to 'data' is ambiguous
L1Trigger/GlobalCaloTrigger/test/testElectronSorter.cpp:230:4: error: reference to 'data' is ambiguous
L1Trigger/GlobalCaloTrigger/test/testElectronSorter.cpp:239:6: error: reference to 'data' is ambiguous
L1Trigger/GlobalCaloTrigger/test/testElectronSorter.cpp:250:16: error: reference to 'data' is ambiguous
RecoVertex/BeamSpotProducer/test/global.h:35:25: error: template argument 1 is invalid
RecoVertex/BeamSpotProducer/test/global.h:35:25: error: template argument 2 is invalid
RecoVertex/BeamSpotProducer/test/global.h:36:31: error: expected initializer before 'zDataConstIter'
RecoVertex/BeamSpotProducer/test/global.h:37:25: error: expected initializer before 'zDataIter'
Avoid using plain 'data', because in C++1z (C++17) there is a new
std::data() function and if using namespace std exist it could
result in unexpected result visible in above diagnotic messages.
Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
|
A new Pull Request was created by @davidlt for CMSSW_8_1_X. It involves the following packages: L1Trigger/GlobalCaloTrigger @cvuosalo, @cerminar, @cmsbuild, @rekovic, @franzoni, @slava77, @mmusich, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
|
@cmsbuild please test |
|
The tests are being triggered in jenkins. |
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While compiling with GCC 6.0.0 (r234771) in C++1z mode compiler
produces extra diagnotic messages:
Avoid using plain 'data', because in C++1z (C++17) there is a new
std::data() function and if using namespace std exist it could
result in unexpected result visible in above diagnotic messages.
Signed-off-by: David Abdurachmanov David.Abdurachmanov@cern.ch