Declare liblogintpack functions as inline #14014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new Pull Request was created by @makortel (Matti Kortelainen) for CMSSW_8_1_X. It involves the following packages: DataFormats/PatCandidates @cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
|
@cmsbuild , please test |
|
The tests are being triggered in jenkins. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the functions are defined in a header, they should be declared inline. Should affect only
testDataFormatsPatCandidates, whichtestlogintpack.ccDataFormats/PatCandidates) that has a source #including the headerWithout declaring the functions inline, if one adds
<use name="vdt"/>toDataFormats/PatCandidates/BuildFile.xml, thestd::expinunpack8logClosedgives 1 ulp difference forunpack8logClosed(-1, -15, 0)wrt. not "using"vdt. Note that the effect is visible only when calling theunpack8logClosedfunction. If I copy-paste the contents to the test program, I get consistently the "not-using-vdt" values. With inline the return value ofunpack8logClosedis does not depend on linking againstvdt.With this PR, the (older version of) #13959 (with
DataFormats/ParticleFlowReco/BuildFile.xmlusingvdtinstead ofvdt_headers) would not causetestDataFormatsPatCandidatesto fail.Tested in 8_1_0_pre2, no changes expected.
@VinInn