Finalizing JSON monitoring for 2016 #14031
Conversation
|
A new Pull Request was created by @avetisya (Aram Avetisyan) for CMSSW_8_1_X. It involves the following packages: HLTrigger/JSONMonitoring @Martin-Grunewald, @perrotta, @cmsbuild, @fwyzard, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
|
please test |
|
The tests are being triggered in jenkins. |
|
+1 |
cmsbuild
added
hlt-approved
fully-signed
and removed
hlt-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
|
|
||
| iSummary->prescaleIndex = 100; | ||
|
|
||
| iSummary->L1AlgoAccept = new HistoJ<unsigned int>(1, MAXPATHS); |
There was a problem hiding this comment.
how do these pointers get deleted?
There was a problem hiding this comment.
The pointers are deleted in the L1TriggerJSONMonitoring::globalEndLuminosityBlockSummary function starting on line 393.
There was a problem hiding this comment.
thanks - they should certainly also be reinitialized to nullptr. Please add a new PR for that. Thanks.
|
+1 |
81X version of #14030 . It's completely identical to the 80X version.