add fillDescriptions function needed by the HLT #14039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new Pull Request was created by @mmarionncern for CMSSW_8_0_X. It involves the following packages: JetMETCorrections/Type1MET @cmsbuild, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
|
please test |
|
The tests are being triggered in jenkins. |
|
-1 runTheMatrix-results/134.911_RunSinglePh2015D+RunSinglePh2015D+HLTDR2_25ns+RECODR2_25nsreHLT+HARVESTDR2_25nsreHLT/step3_RunSinglePh2015D+RunSinglePh2015D+HLTDR2_25ns+RECODR2_25nsreHLT+HARVESTDR2_25nsreHLT.log ----- Begin Fatal Exception 13-Apr-2016 14:39:33 CEST----------------------- An exception of category 'Configuration' occurred while [0] Constructing the EventProcessor [1] Validating configuration of module: class=PATPFJetMETcorrInputProducer label='patPFMetT1T2Corr' Exception Message: Illegal parameters found in configuration. The parameters are named: 'isMC' 'type2ExtraCorrFactor' 'type2ResidualCorrEtaMax' 'type2ResidualCorrLabel' 'type2ResidualCorrOffset' You could be trying to use parameter names that are not allowed for this plugin or they could be misspelled. ----- End Fatal Exception ------------------------------------------------- 135.4 step3 runTheMatrix-results/135.4_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS/step3_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS.log ----- Begin Fatal Exception 13-Apr-2016 14:41:22 CEST----------------------- An exception of category 'Configuration' occurred while [0] Constructing the EventProcessor [1] Validating configuration of module: class=PATPFJetMETcorrInputProducer label='patPFMetT1T2Corr' Exception Message: Illegal parameters found in configuration. The parameters are named: 'isMC' 'type2ExtraCorrFactor' 'type2ResidualCorrEtaMax' 'type2ResidualCorrLabel' 'type2ResidualCorrOffset' You could be trying to use parameter names that are not allowed for this plugin or they could be misspelled. ----- End Fatal Exception ------------------------------------------------- 1306.0 step3 runTheMatrix-results/1306.0_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15/step3_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15.log ----- Begin Fatal Exception 13-Apr-2016 14:43:20 CEST----------------------- An exception of category 'Configuration' occurred while [0] Constructing the EventProcessor [1] Validating configuration of module: class=PATPFJetMETcorrInputProducer label='patPFMetT1T2Corr' Exception Message: Illegal parameters found in configuration. The parameters are named: 'isMC' 'type2ExtraCorrFactor' 'type2ResidualCorrEtaMax' 'type2ResidualCorrLabel' 'type2ResidualCorrOffset' You could be trying to use parameter names that are not allowed for this plugin or they could be misspelled. ----- End Fatal Exception ------------------------------------------------- 1330.0 step3 runTheMatrix-results/1330.0_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15/step3_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15.log ----- Begin Fatal Exception 13-Apr-2016 14:47:17 CEST----------------------- An exception of category 'Configuration' occurred while [0] Constructing the EventProcessor [1] Validating configuration of module: class=PATPFJetMETcorrInputProducer label='patPFMetT1T2Corr' Exception Message: Illegal parameters found in configuration. The parameters are named: 'isMC' 'type2ExtraCorrFactor' 'type2ResidualCorrEtaMax' 'type2ResidualCorrLabel' 'type2ResidualCorrOffset' You could be trying to use parameter names that are not allowed for this plugin or they could be misspelled. ----- End Fatal Exception ------------------------------------------------- 50202.0 step3 runTheMatrix-results/50202.0_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50/step3_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50.log ----- Begin Fatal Exception 13-Apr-2016 15:06:18 CEST----------------------- An exception of category 'Configuration' occurred while [0] Constructing the EventProcessor [1] Validating configuration of module: class=PATPFJetMETcorrInputProducer label='patPFMetT1T2Corr' Exception Message: Illegal parameters found in configuration. The parameters are named: 'isMC' 'type2ExtraCorrFactor' 'type2ResidualCorrEtaMax' 'type2ResidualCorrLabel' 'type2ResidualCorrOffset' You could be trying to use parameter names that are not allowed for this plugin or they could be misspelled. ----- End Fatal Exception ------------------------------------------------- 25202.0 step3 runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25/step3_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25.log ----- Begin Fatal Exception 13-Apr-2016 15:09:22 CEST----------------------- An exception of category 'Configuration' occurred while [0] Constructing the EventProcessor [1] Validating configuration of module: class=PATPFJetMETcorrInputProducer label='patPFMetT1T2Corr' Exception Message: Illegal parameters found in configuration. The parameters are named: 'isMC' 'type2ExtraCorrFactor' 'type2ResidualCorrEtaMax' 'type2ResidualCorrLabel' 'type2ResidualCorrOffset' You could be trying to use parameter names that are not allowed for this plugin or they could be misspelled. ----- End Fatal Exception ------------------------------------------------- you can see the results of the tests here: |
|
Pull request #14039 was updated. @cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please check and sign again. |
|
please test |
|
The tests are being triggered in jenkins. |
|
+1 Adding fillDescriptions methods to two MET producer modules. There should be no change in monitored quantities. #14040 is the 81X version of this PR. The code changes are satisfactory, and Jenkins tests against baseline CMSSW_8_0_X_2016-04-14-2300 show no significant differences, as expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR only adds the fillDecription function for two modules that are needed by the HLT.
Changes expected in physics results and performances : none
Packages touched :