SIM code cleanup #14050
SIM code cleanup #14050
Conversation
|
A new Pull Request was created by @civanch (Vladimir Ivantchenko) for CMSSW_8_1_X. It involves the following packages: SimG4CMS/HcalTestBeam @cmsbuild, @civanch, @mdhildreth, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
|
please test |
|
The tests are being triggered in jenkins. |
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
cmsbuild
added
simulation-approved
fully-signed
and removed
pending-signatures
simulation-pending
labels
cmsbuild
added
simulation-pending
and removed
comparison-available
fully-signed
simulation-approved
tests-approved
labels
|
Pull request #14050 was updated. @cmsbuild, @civanch, @mdhildreth, @davidlange6 can you please check and sign again. |
|
please test |
|
+1 |
cmsbuild
added
simulation-approved
fully-signed
and removed
pending-signatures
simulation-pending
labels
|
The tests are being triggered in jenkins. |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
|
+1 |
Fixed some static analyser warnings; removed commented lines and unused headers; added getByToken; added c++11 keywords. For HcalTestBeam enable Russian roulette by default; fixed sampling of noise in HCAL.