Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Save L1 stage2 info in offline data tiers (81X) #14051

Merged
merged 3 commits into from
Apr 22, 2016
Merged

Save L1 stage2 info in offline data tiers (81X) #14051

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
eb83a83
Add stage2 L1 objects in all event contents that had l1extraParticles
gpetruc Apr 13, 2016
ada9f03
Add stage 2 L1 trigger info to MiniAOD
gpetruc Apr 7, 2016
9f216c9
Update to use the more proper era.toModify syntax
gpetruc Apr 14, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
18 changes: 18 additions & 0 deletions L1Trigger/Configuration/python/L1Trigger_EventContent_cff.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import FWCore.ParameterSet.Config as cms
from Configuration.StandardSequences.Eras import eras

# RAW content
L1TriggerRAW = cms.PSet(
Expand Down Expand Up @@ -93,3 +94,20 @@
'keep LumiSummary_lumiProducer_*_*')
)


if eras.stage2L1Trigger.isChosen():
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this syntax is strongly discouraged

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took it from another L1Trigger cff file, assuming it was the right thing to do.
What's the right syntax?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I missed your question earlier.

use simply toModify with a function

def _appendStage2Digis(obj):
    l1Stage2Digis = [
        'keep *_gtStage2Digis__*',
        'keep *_gmtStage2Digis_Muon_*',
        'keep *_caloStage2Digis_Jet_*',
        'keep *_caloStage2Digis_Tau_*',
        'keep *_caloStage2Digis_EGamma_*',
        'keep *_caloStage2Digis_EtSum_*',
        ]
    obj.outputCommands += l1Stage2Digis

eras.stage2L1Trigger.toModify(L1TriggerRAWDEBUG, func=_appendStage2Digis)
eras.stage2L1Trigger.toModify(L1TriggerRECO, func=_appendStage2Digis)
eras.stage2L1Trigger.toModify(L1TriggerAOD, func=_appendStage2Digis)
eras.stage2L1Trigger.toModify(L1TriggerFEVTDEBUG, func=_appendStage2Digis)

# stage 2 L1 trigger
l1Stage2Digis = [
'keep *_gtStage2Digis__*',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there should be a star between the two underscores....

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not put the star on purpose, as my understanding from the email thread was that for the GT we wanted only the bits (GlobalAlgBlk and GlobalExtBlk) which have an empty instance label, and not also all the other collections (muons, jets, taus, etc).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure it is the correct syntax in this case?

'keep *_gmtStage2Digis_Muon_*',
'keep *_caloStage2Digis_Jet_*',
'keep *_caloStage2Digis_Tau_*',
'keep *_caloStage2Digis_EGamma_*',
'keep *_caloStage2Digis_EtSum_*',
]
# adding them to all places where we had l1extraParticles
L1TriggerRAWDEBUG.outputCommands += l1Stage2Digis
L1TriggerRECO.outputCommands += l1Stage2Digis
L1TriggerAOD.outputCommands += l1Stage2Digis
L1TriggerFEVTDEBUG.outputCommands += l1Stage2Digis

9 changes: 9 additions & 0 deletions PhysicsTools/PatAlgos/python/slimming/MicroEventContent_cff.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,17 @@
'keep patPackedTriggerPrescales_patTrigger__*',
'keep patPackedTriggerPrescales_patTrigger_l1max_*',
'keep patPackedTriggerPrescales_patTrigger_l1min_*',
# old L1 trigger
'keep *_l1extraParticles_*_*',
'keep L1GlobalTriggerReadoutRecord_gtDigis_*_*',
# stage 2 L1 trigger
'keep *_gtStage2Digis__*',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there should be a star between the two underscores....

'keep *_gmtStage2Digis_Muon_*',
'keep *_caloStage2Digis_Jet_*',
'keep *_caloStage2Digis_Tau_*',
'keep *_caloStage2Digis_EGamma_*',
'keep *_caloStage2Digis_EtSum_*',
# HLT
'keep *_TriggerResults_*_HLT',
'keep *_TriggerResults_*_*', # for MET filters (a catch all for the moment, but ideally it should be only the current process)
'keep patPackedCandidates_lostTracks_*_*',
Expand Down