New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for runtestTqafTopEventSelection unit test #14055
Fix for runtestTqafTopEventSelection unit test #14055
Conversation
…ooseMVA6 instead of againstElectronVLooseMVA5
A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for CMSSW_8_1_X. It involves the following packages: PhysicsTools/PatAlgos @cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
please test |
The tests are being triggered in jenkins. |
@davidlange6 , if this fix is not correct then I can disable the test |
@@ -8,7 +8,7 @@ | |||
'tauID("decayModeFinding") > 0.5 &' | |||
' tauID("byLooseCombinedIsolationDeltaBetaCorr3Hits") > 0.5 &' | |||
' tauID("againstMuonTight3") > 0.5 &' | |||
' tauID("againstElectronVLooseMVA5") > 0.5' | |||
' tauID("againstElectronVLooseMVA6") > 0.5' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks sensible
@roger-wolf please confirm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @slava77
yes this change makes sense and should be applied. MVA6 replaced MVA5 with same functionality and purpose.
Cheers,
Roger
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Roger,
It would be nice to have a single source of settings here and in the PhysicsTools/PatAlgos/python/tools/tauTools.py
It looks like PATTauCleaner is not running in miniAOD setup. So, this is an item not affecting the production workflows.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @slava77,
sure I can take care of this within the next days and bubble it in along with other maintenance changes. It's on my list.
Cheers,
Roger
+1
|
use againstElectronVLooseMVA6 instead of againstElectronVLooseMVA5