Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for runtestTqafTopEventSelection unit test #14055

Merged
merged 1 commit into from Apr 14, 2016
Merged

Fix for runtestTqafTopEventSelection unit test #14055

merged 1 commit into from Apr 14, 2016

Conversation

smuzaffar
Copy link
Contributor

use againstElectronVLooseMVA6 instead of againstElectronVLooseMVA5

…ooseMVA6 instead of againstElectronVLooseMVA5
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for CMSSW_8_1_X.

It involves the following packages:

PhysicsTools/PatAlgos

@cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@TaiSakuma, @imarches, @ahinzmann, @acaudron, @mmarionncern, @rappoccio, @jdolen, @nhanvtran, @schoef, @ferencek, @gpetruc, @mariadalfonso, @pvmulder this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12351/console

@smuzaffar
Copy link
Contributor Author

@davidlange6 , if this fix is not correct then I can disable the test

@@ -8,7 +8,7 @@
'tauID("decayModeFinding") > 0.5 &'
' tauID("byLooseCombinedIsolationDeltaBetaCorr3Hits") > 0.5 &'
' tauID("againstMuonTight3") > 0.5 &'
' tauID("againstElectronVLooseMVA5") > 0.5'
' tauID("againstElectronVLooseMVA6") > 0.5'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks sensible
@roger-wolf please confirm

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @slava77
yes this change makes sense and should be applied. MVA6 replaced MVA5 with same functionality and purpose.
Cheers,
Roger

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Roger,

It would be nice to have a single source of settings here and in the PhysicsTools/PatAlgos/python/tools/tauTools.py

It looks like PATTauCleaner is not running in miniAOD setup. So, this is an item not affecting the production workflows.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @slava77,

sure I can take care of this within the next days and bubble it in along with other maintenance changes. It's on my list.

Cheers,
Roger

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented Apr 14, 2016

+1

for #14055 7b86dbd

  • change PATTauCleaner configuration in tauCleaner_cfi.py brings selections to the currently used/available tauID and makes it in line with definitions used in PhysicsTools/PatAlgos/python/tools/tauTools.py switchToPFTauHPS method. PATTauCleaner is not running in production workflows.
  • jenkins tests pass and comparisons with baseline show no difference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants